dtoro
fb39a48bef
internal/httpapi/phase3.go (2627 lines, 12+ resource domains) split into 15 per-resource files: - actuator.go: SSH execution machinery (initSSH, sshExec, resolveRunTarget, executeApprovedAction, jsonErr, gatewayPreflightPassed, resolveTemplate) - checks.go, classifications.go, executions.go, approvals.go, patterns.go, skills.go, approval_rules.go, autonomy.go, risk_classes.go, relationships.go, entity_types.go, metrics.go, agent_activity.go, helpers.go — one file per resource domain, each with its own imports. internal/mcp/server.go: newServer (708 lines, 33 inline tool registrations) refactored to a registry pattern: - internal/mcp/tools.go (new): toolReg struct + allTools() returning all 33 tool definitions. Handler logic moved verbatim — no changes to tool names, descriptions, schemas, or behavior. - server.go: newServer is now 9 lines (iterate registry, AddTool each). -699 lines. No function logic, names, or signatures changed. go vet, build, and all tests pass (httpapi, mcp, db, policy).
205 lines
8.0 KiB
Markdown
205 lines
8.0 KiB
Markdown
# Contributing to Oikos
|
|
|
|
Developer guide for the Oikos codebase. If you are a homelab client consuming
|
|
Oikos, see [CLIENTS.md](CLIENTS.md). If you are an AI agent working on the
|
|
repo, see [.agents/dev/CONTRIBUTING.md](.agents/dev/CONTRIBUTING.md).
|
|
|
|
## Dev setup
|
|
|
|
- **Go 1.26+** (see `go.mod` for pinned version)
|
|
- **PostgreSQL with TimescaleDB** — the compose stack includes `timescale/timescaledb:2.17.2-pg16`
|
|
- **Docker** for the full dev stack
|
|
- **Node 22+** for `web/` (the control-room SPA — standalone, not part of the
|
|
compose stack or the `oikos` binary)
|
|
|
|
```bash
|
|
# Start dependencies (Postgres + Redis). api/nomos require a shared bearer
|
|
# token — no dev-open bypass — so set one even for local dev.
|
|
OIKOS_MCP_BEARER_TOKEN=dev-token docker compose --profile dev up -d
|
|
|
|
# Run all tests
|
|
make test
|
|
|
|
# Run integration tests (needs compose Postgres)
|
|
make test-db
|
|
|
|
# Build the binary
|
|
make build
|
|
|
|
# SPA dev server (proxies to api/nomos, injecting the same token)
|
|
cd web && OIKOS_API_TOKEN=dev-token npm run dev
|
|
|
|
# Desktop app (macOS)
|
|
make desktop # build .app bundle
|
|
make install # build + install to /Applications
|
|
./cmd/desktop/build/bin/oikos-desktop.app/Contents/MacOS/oikos-desktop # run from terminal to see logs
|
|
```
|
|
|
|
### Desktop app auth
|
|
|
|
The desktop app uses the same API as the browser SPA. First launch:
|
|
|
|
1. Enter `https://oikos.hubris.network` as Server URL
|
|
2. **Login with Authentik** tab → opens system browser → authenticate
|
|
3. Callback page shows token → copy → paste into Token tab → Connect
|
|
4. Token is persisted to the macOS keychain — subsequent launches skip setup
|
|
|
|
The app stores credentials via `github.com/zalando/go-keyring` (service: `com.hubris.oikos-desktop`).
|
|
|
|
### Desktop app auto-update
|
|
|
|
- Checks Gitea releases every 6 hours
|
|
- System tray → **Check for Updates** triggers an immediate check
|
|
- Download, extract, replace the app in `/Applications`, and relaunch
|
|
- Versions are compared against the `version` var in `main.go`, injected from the repo `VERSION` file at link time (`make desktop` passes `-ldflags "-X main.version=$(cat VERSION)"`)
|
|
|
|
## Project structure
|
|
|
|
```
|
|
cmd/desktop/ Wails v3 desktop app (macOS + Linux)
|
|
main.go Thin shell: webview, system tray, notifications, auto-update
|
|
wails.json Wails project config
|
|
entitlements.plist macOS code-signing entitlements
|
|
icon.png System tray icon (embedded)
|
|
icon.icns App bundle icon (white logo on black rounded rect)
|
|
Taskfile.yml Wails v3 build tasks
|
|
Info.plist.template macOS bundle metadata
|
|
cmd/oikos/ Single-binary entry point
|
|
cmd/nomos/ Nomos MCP client gateway
|
|
cmd/webhook/ Gitea deploy-webhook receiver (push-to-deploy on mac-mini)
|
|
internal/ All Go packages
|
|
httpapi/ REST + MCP server (OpenAPI-generated)
|
|
mcp/ MCP tool implementations
|
|
db/ Connection pool, migrations, seeds, sqlc queries
|
|
scheduler/ Observe loop, probes, signals
|
|
actuator/ SSH execution
|
|
learning/ Pattern recognition, anomaly detection
|
|
notifier/ Matrix notifications, approval tokens
|
|
policy/ Risk classifier
|
|
secrets/ Infisical + SOPS backend
|
|
domain/ Core types: entities, approvals, signals, patterns
|
|
ontology/ Type hierarchy, relationship validation
|
|
knowledge/ Knowledge YAML seed ingestion
|
|
web/ Control-room SPA (Svelte 5) — standalone, not embedded
|
|
in the oikos binary; see plans/2026-07-12-wails-desktop-app.md
|
|
api/openapi.yaml API contract — the source of truth for endpoints
|
|
migrations/ Forward-only SQL migrations (TimescaleDB)
|
|
seeds/ Bootstrap YAML: ontology, inventory, policy, knowledge
|
|
compose/ Dockerfiles + Caddy config
|
|
scripts/ Deploy, watchdog, rollback
|
|
checks/ Host health-check scripts run over SSH by the scheduler
|
|
tools/ Client auto-setup scripts (checks)
|
|
nomos/ Nomos config, persona, skills
|
|
.agents/ Agent instruction files + skills
|
|
plans/ Design documents
|
|
docs/adr/ Architecture decision records
|
|
docs/operations/ Runbooks (rollback, etc.)
|
|
```
|
|
|
|
## Commands
|
|
|
|
| Command | Purpose |
|
|
|---------|---------|
|
|
| `make build` | Build `oikos` binary |
|
|
| `make test` | Run all tests with race detection |
|
|
| `make test-db` | Run integration tests against compose Postgres |
|
|
| `make lint` | `go vet` + `golangci-lint` |
|
|
| `make generate` | Regenerate OpenAPI + sqlc code |
|
|
| `make generate-check` | CI drift guard — fail if generated code is stale |
|
|
| `make migrate` | Apply DB migrations |
|
|
| `make seed` | Ingest seeds into DB |
|
|
| `make export` | Export DB state to YAML seeds |
|
|
| `make dev` | Start compose dev stack |
|
|
| `make clean` | Remove binary + test cache |
|
|
| `make ui` | Build the SPA (`web/dist/`) |
|
|
| `make deploy-ui` | Build + deploy the SPA to the Caddy host |
|
|
| `make desktop` | Build the Wails desktop app for the current platform |
|
|
| `make desktop-package` | Build + package (zip on macOS, tar.gz on Linux) |
|
|
| `make install` | Build + install to `/Applications` (macOS) |
|
|
| `make webhook` | Build `cmd/webhook` (deploy-webhook receiver) |
|
|
| `make tidy` | `go mod tidy` |
|
|
|
|
## Conventions
|
|
|
|
### APIs are OpenAPI-first
|
|
|
|
The REST API is defined in `api/openapi.yaml`. Server code is generated with
|
|
`oapi-codegen` into `internal/httpapi/gen/`. To add an endpoint:
|
|
|
|
1. Add the path + schema to `api/openapi.yaml`
|
|
2. Run `make generate`
|
|
3. Implement the handler in `internal/httpapi/impl.go`
|
|
4. Add tests in `internal/httpapi/api_test.go`
|
|
|
|
Never hand-edit `internal/httpapi/gen/api.gen.go`.
|
|
|
|
### Database access is sqlc-first
|
|
|
|
SQL queries live in `internal/db/queries/*.sql`. Go code is generated with
|
|
`sqlc` into `internal/db/sqlcgen/`. Config in `sqlc.yaml`.
|
|
|
|
- Queries target pgx/v5 with UUID + timestamptz overrides
|
|
- Never hand-edit generated sqlc code
|
|
|
|
### Migrations are forward-only
|
|
|
|
SQL migrations live in `migrations/` as `NNN_name.up.sql`. There are no down
|
|
migrations (see [ADR 0008](docs/adr/0008-forward-only-migrations.md)).
|
|
Migrations are idempotent where possible (`IF NOT EXISTS`, `DO $$` blocks).
|
|
|
|
To add a migration:
|
|
|
|
1. Create `migrations/NNN_name.up.sql` with the next sequence number
|
|
2. Write the DDL
|
|
3. Run `make migrate` to apply
|
|
|
|
### Seeds are DB-generated
|
|
|
|
`seeds/*.yaml` are the bootstrap files used by `oikos seed`. After making
|
|
changes via the API, run `make export` to regenerate the seed files. These
|
|
files are version-controlled and serve as DR fallback.
|
|
|
|
### Writing style
|
|
|
|
Follow [.agents/shared/writing-style.md](.agents/shared/writing-style.md).
|
|
Documentation is reference prose, not marketing. Banned vocabulary includes
|
|
"robust", "seamless", "leverage", "utilize", "delve", "cutting-edge".
|
|
|
|
### Risk classification
|
|
|
|
Every mutation is classified against `seeds/policy.yaml` before execution.
|
|
Four risk classes: `read_only`, `reversible_low`, `config_mutation`,
|
|
`destructive`. The classifier can only lower autonomy relative to policy,
|
|
never raise it. When in doubt, escalate.
|
|
|
|
## CI
|
|
|
|
Gitea Actions runs on push to `main` and pull requests (`ci.yml`):
|
|
|
|
1. `go vet` + `golangci-lint` + `govulncheck`
|
|
2. Generated code drift check (`make generate-check`)
|
|
3. Build (`go build ./...`)
|
|
4. Test with race detector + coverage
|
|
5. Docker build verification (no push)
|
|
|
|
Coverage gates: policy + learning packages ≥ 80%, others ≥ 60%.
|
|
|
|
## PR workflow
|
|
|
|
1. Create a branch from `main`
|
|
2. Make changes, write tests
|
|
3. Run `make lint test generate-check`
|
|
4. Commit with a message following: problem → change → risk → verification
|
|
5. Push to Gitea; CI gates PRs on green
|
|
|
|
## Secrets
|
|
|
|
Secrets are managed by Infisical (primary) with SOPS as DR fallback. Never
|
|
hardcode secrets. Use environment variables from `.env` for local dev.
|
|
The `.env` and `.infisical-credentials` files are gitignored.
|
|
|
|
## Related
|
|
|
|
- [OIKOS.md](.agents/OIKOS.md) — operating model, OODA loop, ontology
|
|
- [CLIENTS.md](CLIENTS.md) — for homelab clients consuming Oikos
|
|
- [docs/adr/](docs/adr/) — architecture decision records |