dtoro
d2950dd09d
Deleted 8 genuinely unused sqlc queries (no inline equivalent): - UpsertCurrentRelationship, ListEntitiesCapped, ListEntityStatus, UpdateSignalState, InsertClassification, InsertFeedback, InsertSkill, UpsertCurrentRelationship — all had zero call sites. Migrated 9 inline raw SQL sites to use sqlc queries: - GetOntology (impl.go): ListEntityTypes, ListRelationshipTypes, ListLifecycleDefs — replaces 3 raw pool.Query blocks with typed sqlcgen calls, eliminating manual row scanning. - EndRelationship (phase3.go): EndCurrentRelationship — replaces tx.Exec with sqlcgen.New(tx).EndCurrentRelationship. - checkPrecondition (impl.go): GetEntityStatus — replaces tx.QueryRow + manual Scan with sqlcgen.New(tx).GetEntityStatus. - GetEntityRelations (impl.go): ListEntityRelations — replaces raw pool.Query + scanRelationships helper (now deleted). - GetGraph (impl.go): ListGraphEdges — replaces raw pool.Query + scanRelationships. - resolveEntityID (impl.go): GetEntityBySlug/GetEntityByID — replaces raw pool.QueryRow + Scan. - createApproval (mcp/server.go): InsertApproval — replaces raw pool.Exec with sqlcgen.InsertApproval. Deleted scanRelationships helper (was only used by the two migrated graph queries above). Regenerated sqlcgen — also picks up stale model updates (AgentSession, SessionPlanStep, SessionQuestion, etc. from recent migrations). Documented the carve-out in .agents/dev/CONTRIBUTING.md §SQL conventions: sqlc is the default; raw pool.Query/Exec is reserved for LISTEN/NOTIFY, dynamic WHERE builders, blast_radius(), and COPY. go vet, build, httpapi/mcp/db tests all pass. -383/+170 lines.
28 lines
1.2 KiB
SQL
28 lines
1.2 KiB
SQL
-- name: ListEntityRelations :many
|
|
SELECT se.slug AS source_slug, te.slug AS target_slug, r.type, r.attributes,
|
|
r.valid_from, r.valid_to
|
|
FROM relationships r
|
|
JOIN entities se ON se.id = r.source_id
|
|
JOIN entities te ON te.id = r.target_id
|
|
WHERE r.valid_to IS NULL
|
|
AND ((sqlc.arg('direction')::text IN ('out','both') AND r.source_id = sqlc.arg('id'))
|
|
OR (sqlc.arg('direction')::text IN ('in','both') AND r.target_id = sqlc.arg('id')))
|
|
AND (sqlc.narg('rel_type')::text IS NULL OR r.type = sqlc.narg('rel_type'))
|
|
ORDER BY r.type, se.slug, te.slug;
|
|
|
|
-- name: ListGraphEdges :many
|
|
SELECT se.slug AS source_slug, te.slug AS target_slug, r.type, r.attributes,
|
|
r.valid_from, r.valid_to
|
|
FROM relationships r
|
|
JOIN entities se ON se.id = r.source_id
|
|
JOIN entities te ON te.id = r.target_id
|
|
WHERE r.valid_to IS NULL
|
|
AND r.source_id = ANY(sqlc.arg('ids')::uuid[])
|
|
AND r.target_id = ANY(sqlc.arg('ids')::uuid[])
|
|
AND (sqlc.narg('rel_types')::text[] IS NULL OR r.type = ANY(sqlc.narg('rel_types')::text[]))
|
|
ORDER BY r.type, se.slug, te.slug;
|
|
|
|
-- name: EndCurrentRelationship :execrows
|
|
UPDATE relationships SET valid_to = now()
|
|
WHERE source_id = $1 AND target_id = $2 AND type = $3 AND valid_to IS NULL;
|