dtoro
0c0f35a3a9
Phase 0 of plans/2026-07-12-wails-desktop-app.md. The control-room SPA is no longer embedded (web/embed.go deleted); it's a standalone static build served separately (make ui / make deploy-ui). The api process adds CORS and drops the dev-open auth bypass — every route now needs a real bearer token, including SSE (?token= query param, EventSource can't set headers) and api's own /agent proxy to nomos (previously unauthenticated by omission). nomos was an unauthenticated client of api's /mcp and approval-decision endpoints; closing dev-open would have broken it, so it now sends Authorization: Bearer $OIKOS_MCP_BEARER_TOKEN on every call back to api. SPA gets a runtime config module (config.ts) and a Config.svelte first-launch/reconfigure page, reachable afterwards via a "Connection" entry in the sidebar footer. Every fetch() in api.ts routes through fetchWithAuth so the same build works same-origin (browser prod, Vite dev proxy) or cross-origin (future Wails webview, remote access). Six gaps found against the plan and the live Caddy topology while implementing — documented in the plan's "Plan review" section, most notably: api's own /agent mount was never behind combinedAuth (fixed), and production's Authentik forward-auth needs a bearer-token bypass for API routes that this repo's Caddyfile.oikos reference copy now has, but the real dtoro/caddy-conf deploy does not yet. Verified live: cross-origin static SPA + API, CORS, bearer auth, SSE query-token auth, and localStorage persistence all confirmed working in-browser. Full Go test suite and npm run build pass with no regressions against the pre-change baseline. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
165 lines
5.9 KiB
Markdown
165 lines
5.9 KiB
Markdown
# Contributing to Oikos
|
|
|
|
Developer guide for the Oikos codebase. If you are a homelab client consuming
|
|
Oikos, see [CLIENTS.md](CLIENTS.md). If you are an AI agent working on the
|
|
repo, see [.agents/dev/CONTRIBUTING.md](.agents/dev/CONTRIBUTING.md).
|
|
|
|
## Dev setup
|
|
|
|
- **Go 1.26+** (see `go.mod` for pinned version)
|
|
- **PostgreSQL with TimescaleDB** — the compose stack includes `timescale/timescaledb:2.17.2-pg16`
|
|
- **Docker** for the full dev stack
|
|
- **Node 22+** for `web/` (the control-room SPA — standalone, not part of the
|
|
compose stack or the `oikos` binary)
|
|
|
|
```bash
|
|
# Start dependencies (Postgres + Redis). api/nomos require a shared bearer
|
|
# token — no dev-open bypass — so set one even for local dev.
|
|
OIKOS_MCP_BEARER_TOKEN=dev-token docker compose --profile dev up -d
|
|
|
|
# Run all tests
|
|
make test
|
|
|
|
# Run integration tests (needs compose Postgres)
|
|
make test-db
|
|
|
|
# Build the binary
|
|
make build
|
|
|
|
# SPA dev server (proxies to api/nomos, injecting the same token)
|
|
cd web && OIKOS_API_TOKEN=dev-token npm run dev
|
|
```
|
|
|
|
## Project structure
|
|
|
|
```
|
|
cmd/oikos/ Single-binary entry point
|
|
cmd/nomos/ Nomos MCP client gateway
|
|
internal/ All Go packages
|
|
httpapi/ REST + MCP server (OpenAPI-generated)
|
|
mcp/ MCP tool implementations
|
|
db/ Connection pool, migrations, seeds, sqlc queries
|
|
scheduler/ Observe loop, probes, signals
|
|
actuator/ SSH execution
|
|
learning/ Pattern recognition, anomaly detection
|
|
notifier/ Matrix notifications, approval tokens
|
|
policy/ Risk classifier
|
|
secrets/ Infisical + SOPS backend
|
|
domain/ Core types: entities, approvals, signals, patterns
|
|
ontology/ Type hierarchy, relationship validation
|
|
knowledge/ Knowledge YAML seed ingestion
|
|
web/ Control-room SPA (Svelte 5) — standalone, not embedded
|
|
in the oikos binary; see plans/2026-07-12-wails-desktop-app.md
|
|
api/openapi.yaml API contract — the source of truth for endpoints
|
|
migrations/ Forward-only SQL migrations (TimescaleDB)
|
|
seeds/ Bootstrap YAML: ontology, inventory, policy, knowledge
|
|
compose/ Dockerfiles + Caddy config
|
|
scripts/ Deploy, watchdog, rollback
|
|
nomos/ Nomos config, persona, skills
|
|
.agents/ Agent instruction files + skills
|
|
plans/ Design documents
|
|
docs/adr/ Architecture decision records
|
|
```
|
|
|
|
## Commands
|
|
|
|
| Command | Purpose |
|
|
|---------|---------|
|
|
| `make build` | Build `oikos` binary |
|
|
| `make test` | Run all tests with race detection |
|
|
| `make test-db` | Run integration tests against compose Postgres |
|
|
| `make lint` | `go vet` + `golangci-lint` |
|
|
| `make generate` | Regenerate OpenAPI + sqlc code |
|
|
| `make generate-check` | CI drift guard — fail if generated code is stale |
|
|
| `make migrate` | Apply DB migrations |
|
|
| `make seed` | Ingest seeds into DB |
|
|
| `make export` | Export DB state to YAML seeds |
|
|
| `make dev` | Start compose dev stack |
|
|
| `make clean` | Remove binary + test cache |
|
|
| `make ui` | Build the SPA (`web/dist/`) |
|
|
| `make deploy-ui` | Build + deploy the SPA to the Caddy host |
|
|
|
|
## Conventions
|
|
|
|
### APIs are OpenAPI-first
|
|
|
|
The REST API is defined in `api/openapi.yaml`. Server code is generated with
|
|
`oapi-codegen` into `internal/httpapi/gen/`. To add an endpoint:
|
|
|
|
1. Add the path + schema to `api/openapi.yaml`
|
|
2. Run `make generate`
|
|
3. Implement the handler in `internal/httpapi/impl.go`
|
|
4. Add tests in `internal/httpapi/api_test.go`
|
|
|
|
Never hand-edit `internal/httpapi/gen/api.gen.go`.
|
|
|
|
### Database access is sqlc-first
|
|
|
|
SQL queries live in `internal/db/queries/*.sql`. Go code is generated with
|
|
`sqlc` into `internal/db/sqlcgen/`. Config in `sqlc.yaml`.
|
|
|
|
- Queries target pgx/v5 with UUID + timestamptz overrides
|
|
- Never hand-edit generated sqlc code
|
|
|
|
### Migrations are forward-only
|
|
|
|
SQL migrations live in `migrations/` as `NNN_name.up.sql`. There are no down
|
|
migrations (see [ADR 0008](docs/adr/0008-forward-only-migrations.md)).
|
|
Migrations are idempotent where possible (`IF NOT EXISTS`, `DO $$` blocks).
|
|
|
|
To add a migration:
|
|
|
|
1. Create `migrations/NNN_name.up.sql` with the next sequence number
|
|
2. Write the DDL
|
|
3. Run `make migrate` to apply
|
|
|
|
### Seeds are DB-generated
|
|
|
|
`seeds/*.yaml` are the bootstrap files used by `oikos seed`. After making
|
|
changes via the API, run `make export` to regenerate the seed files. These
|
|
files are version-controlled and serve as DR fallback.
|
|
|
|
### Writing style
|
|
|
|
Follow [.agents/shared/writing-style.md](.agents/shared/writing-style.md).
|
|
Documentation is reference prose, not marketing. Banned vocabulary includes
|
|
"robust", "seamless", "leverage", "utilize", "delve", "cutting-edge".
|
|
|
|
### Risk classification
|
|
|
|
Every mutation is classified against `seeds/policy.yaml` before execution.
|
|
Four risk classes: `read_only`, `reversible_low`, `config_mutation`,
|
|
`destructive`. The classifier can only lower autonomy relative to policy,
|
|
never raise it. When in doubt, escalate.
|
|
|
|
## CI
|
|
|
|
Gitea Actions runs on push to `main` and pull requests (`ci.yml`):
|
|
|
|
1. `go vet` + `golangci-lint` + `govulncheck`
|
|
2. Generated code drift check (`make generate-check`)
|
|
3. Build (`go build ./...`)
|
|
4. Test with race detector + coverage
|
|
5. Docker build verification (no push)
|
|
|
|
Coverage gates: policy + learning packages ≥ 80%, others ≥ 60%.
|
|
|
|
## PR workflow
|
|
|
|
1. Create a branch from `main`
|
|
2. Make changes, write tests
|
|
3. Run `make lint test generate-check`
|
|
4. Commit with a message following: problem → change → risk → verification
|
|
5. Push to Gitea; CI gates PRs on green
|
|
|
|
## Secrets
|
|
|
|
Secrets are managed by Infisical (primary) with SOPS as DR fallback. Never
|
|
hardcode secrets. Use environment variables from `.env` for local dev.
|
|
The `.env` and `.infisical-credentials` files are gitignored.
|
|
|
|
## Related
|
|
|
|
- [OIKOS.md](.agents/OIKOS.md) — operating model, OODA loop, ontology
|
|
- [CLIENTS.md](CLIENTS.md) — for homelab clients consuming Oikos
|
|
- [docs/adr/](docs/adr/) — architecture decision records |