Problem: the hexagonal refactor churns the backend tree for nine more phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper, compose/web image) must move to its own repo first so doc/layout rewrites land once on a backend-only tree. Change: - New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/ (updateURL repointed to oikos-web releases), compose/, own CI (web + desktop jobs), own deploy script (CI-green gate, TOCTOU guard, version-tagged images, prune-to-3), own webhook receiver on :9798 + launchd unit, own compose project publishing the same 8091:80. - Cutover executed on mac-mini in order: oikos stack's web service stopped+removed, oikos-web project brought up on 8091; outer Caddy untouched (targets the published port) — serving + Authentik flow + /wails 404 quirk verified post-cutover. - Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install targets, the compose web service, oikos-web from deploy.sh's fallback prune list; wails + go-keyring dropped from go.mod, vendor synced. - README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now point at the new repo; mbse + mascot design docs carry a path note. Risk: production SPA serving depends on the new pipeline now; rollback is versioned-image re-up of the old web service from a pre-split checkout (port 8091). Desktop builds installed before the split still check dtoro/oikos releases — one manual reinstall, noted in the oikos-web release notes. Verification: go vet, make test (race), make generate-check, golangci (no new findings; baseline down 400→365); post-cutover curls — localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
206 lines
5.1 KiB
JavaScript
206 lines
5.1 KiB
JavaScript
/**
|
|
* @fileoverview Rule to validate spacing before function paren.
|
|
* @author Mathias Schreck <https://github.com/lo1tuma>
|
|
* @deprecated in ESLint v8.53.0
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
deprecated: {
|
|
message: "Formatting rules are being moved out of ESLint core.",
|
|
url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
|
|
deprecatedSince: "8.53.0",
|
|
availableUntil: "11.0.0",
|
|
replacedBy: [
|
|
{
|
|
message:
|
|
"ESLint Stylistic now maintains deprecated stylistic core rules.",
|
|
url: "https://eslint.style/guide/migration",
|
|
plugin: {
|
|
name: "@stylistic/eslint-plugin",
|
|
url: "https://eslint.style",
|
|
},
|
|
rule: {
|
|
name: "space-before-function-paren",
|
|
url: "https://eslint.style/rules/space-before-function-paren",
|
|
},
|
|
},
|
|
],
|
|
},
|
|
type: "layout",
|
|
|
|
docs: {
|
|
description:
|
|
"Enforce consistent spacing before `function` definition opening parenthesis",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/space-before-function-paren",
|
|
},
|
|
|
|
fixable: "whitespace",
|
|
|
|
schema: [
|
|
{
|
|
oneOf: [
|
|
{
|
|
enum: ["always", "never"],
|
|
},
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
anonymous: {
|
|
enum: ["always", "never", "ignore"],
|
|
},
|
|
named: {
|
|
enum: ["always", "never", "ignore"],
|
|
},
|
|
asyncArrow: {
|
|
enum: ["always", "never", "ignore"],
|
|
},
|
|
},
|
|
additionalProperties: false,
|
|
},
|
|
],
|
|
},
|
|
],
|
|
|
|
messages: {
|
|
unexpectedSpace: "Unexpected space before function parentheses.",
|
|
missingSpace: "Missing space before function parentheses.",
|
|
},
|
|
},
|
|
|
|
create(context) {
|
|
const sourceCode = context.sourceCode;
|
|
const baseConfig =
|
|
typeof context.options[0] === "string"
|
|
? context.options[0]
|
|
: "always";
|
|
const overrideConfig =
|
|
typeof context.options[0] === "object" ? context.options[0] : {};
|
|
|
|
/**
|
|
* Determines whether a function has a name.
|
|
* @param {ASTNode} node The function node.
|
|
* @returns {boolean} Whether the function has a name.
|
|
*/
|
|
function isNamedFunction(node) {
|
|
if (node.id) {
|
|
return true;
|
|
}
|
|
|
|
const parent = node.parent;
|
|
|
|
return (
|
|
parent.type === "MethodDefinition" ||
|
|
(parent.type === "Property" &&
|
|
(parent.kind === "get" ||
|
|
parent.kind === "set" ||
|
|
parent.method))
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Gets the config for a given function
|
|
* @param {ASTNode} node The function node
|
|
* @returns {string} "always", "never", or "ignore"
|
|
*/
|
|
function getConfigForFunction(node) {
|
|
if (node.type === "ArrowFunctionExpression") {
|
|
// Always ignore non-async functions and arrow functions without parens, e.g. async foo => bar
|
|
if (
|
|
node.async &&
|
|
astUtils.isOpeningParenToken(
|
|
sourceCode.getFirstToken(node, { skip: 1 }),
|
|
)
|
|
) {
|
|
return overrideConfig.asyncArrow || baseConfig;
|
|
}
|
|
} else if (isNamedFunction(node)) {
|
|
return overrideConfig.named || baseConfig;
|
|
|
|
// `generator-star-spacing` should warn anonymous generators. E.g. `function* () {}`
|
|
} else if (!node.generator) {
|
|
return overrideConfig.anonymous || baseConfig;
|
|
}
|
|
|
|
return "ignore";
|
|
}
|
|
|
|
/**
|
|
* Checks the parens of a function node
|
|
* @param {ASTNode} node A function node
|
|
* @returns {void}
|
|
*/
|
|
function checkFunction(node) {
|
|
const functionConfig = getConfigForFunction(node);
|
|
|
|
if (functionConfig === "ignore") {
|
|
return;
|
|
}
|
|
|
|
const rightToken = sourceCode.getFirstToken(
|
|
node,
|
|
astUtils.isOpeningParenToken,
|
|
);
|
|
const leftToken = sourceCode.getTokenBefore(rightToken);
|
|
const hasSpacing = sourceCode.isSpaceBetweenTokens(
|
|
leftToken,
|
|
rightToken,
|
|
);
|
|
|
|
if (hasSpacing && functionConfig === "never") {
|
|
context.report({
|
|
node,
|
|
loc: {
|
|
start: leftToken.loc.end,
|
|
end: rightToken.loc.start,
|
|
},
|
|
messageId: "unexpectedSpace",
|
|
fix(fixer) {
|
|
const comments =
|
|
sourceCode.getCommentsBefore(rightToken);
|
|
|
|
// Don't fix anything if there's a single line comment between the left and the right token
|
|
if (comments.some(comment => comment.type === "Line")) {
|
|
return null;
|
|
}
|
|
return fixer.replaceTextRange(
|
|
[leftToken.range[1], rightToken.range[0]],
|
|
comments.reduce(
|
|
(text, comment) =>
|
|
text + sourceCode.getText(comment),
|
|
"",
|
|
),
|
|
);
|
|
},
|
|
});
|
|
} else if (!hasSpacing && functionConfig === "always") {
|
|
context.report({
|
|
node,
|
|
loc: rightToken.loc,
|
|
messageId: "missingSpace",
|
|
fix: fixer => fixer.insertTextAfter(leftToken, " "),
|
|
});
|
|
}
|
|
}
|
|
|
|
return {
|
|
ArrowFunctionExpression: checkFunction,
|
|
FunctionDeclaration: checkFunction,
|
|
FunctionExpression: checkFunction,
|
|
};
|
|
},
|
|
};
|