Problem: the hexagonal refactor churns the backend tree for nine more phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper, compose/web image) must move to its own repo first so doc/layout rewrites land once on a backend-only tree. Change: - New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/ (updateURL repointed to oikos-web releases), compose/, own CI (web + desktop jobs), own deploy script (CI-green gate, TOCTOU guard, version-tagged images, prune-to-3), own webhook receiver on :9798 + launchd unit, own compose project publishing the same 8091:80. - Cutover executed on mac-mini in order: oikos stack's web service stopped+removed, oikos-web project brought up on 8091; outer Caddy untouched (targets the published port) — serving + Authentik flow + /wails 404 quirk verified post-cutover. - Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install targets, the compose web service, oikos-web from deploy.sh's fallback prune list; wails + go-keyring dropped from go.mod, vendor synced. - README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now point at the new repo; mbse + mascot design docs carry a path note. Risk: production SPA serving depends on the new pipeline now; rollback is versioned-image re-up of the old web service from a pre-split checkout (port 8091). Desktop builds installed before the split still check dtoro/oikos releases — one manual reinstall, noted in the oikos-web release notes. Verification: go vet, make test (race), make generate-check, golangci (no new findings; baseline down 400→365); post-cutover curls — localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
151 lines
3.7 KiB
JavaScript
151 lines
3.7 KiB
JavaScript
/**
|
|
* @fileoverview Rule to suggest using "Reflect" api over Function/Object methods
|
|
* @author Keith Cirkel <http://keithcirkel.co.uk>
|
|
* @deprecated in ESLint v3.9.0
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Require `Reflect` methods where applicable",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/prefer-reflect",
|
|
},
|
|
|
|
deprecated: {
|
|
message: "The original intention of this rule was misguided.",
|
|
deprecatedSince: "3.9.0",
|
|
availableUntil: null,
|
|
replacedBy: [],
|
|
},
|
|
|
|
schema: [
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
exceptions: {
|
|
type: "array",
|
|
items: {
|
|
enum: [
|
|
"apply",
|
|
"call",
|
|
"delete",
|
|
"defineProperty",
|
|
"getOwnPropertyDescriptor",
|
|
"getPrototypeOf",
|
|
"setPrototypeOf",
|
|
"isExtensible",
|
|
"getOwnPropertyNames",
|
|
"preventExtensions",
|
|
],
|
|
},
|
|
uniqueItems: true,
|
|
},
|
|
},
|
|
additionalProperties: false,
|
|
},
|
|
],
|
|
|
|
messages: {
|
|
preferReflect:
|
|
"Avoid using {{existing}}, instead use {{substitute}}.",
|
|
},
|
|
},
|
|
|
|
create(context) {
|
|
const existingNames = {
|
|
apply: "Function.prototype.apply",
|
|
call: "Function.prototype.call",
|
|
defineProperty: "Object.defineProperty",
|
|
getOwnPropertyDescriptor: "Object.getOwnPropertyDescriptor",
|
|
getPrototypeOf: "Object.getPrototypeOf",
|
|
setPrototypeOf: "Object.setPrototypeOf",
|
|
isExtensible: "Object.isExtensible",
|
|
getOwnPropertyNames: "Object.getOwnPropertyNames",
|
|
preventExtensions: "Object.preventExtensions",
|
|
};
|
|
|
|
const reflectSubstitutes = {
|
|
apply: "Reflect.apply",
|
|
call: "Reflect.apply",
|
|
defineProperty: "Reflect.defineProperty",
|
|
getOwnPropertyDescriptor: "Reflect.getOwnPropertyDescriptor",
|
|
getPrototypeOf: "Reflect.getPrototypeOf",
|
|
setPrototypeOf: "Reflect.setPrototypeOf",
|
|
isExtensible: "Reflect.isExtensible",
|
|
getOwnPropertyNames: "Reflect.getOwnPropertyNames",
|
|
preventExtensions: "Reflect.preventExtensions",
|
|
};
|
|
|
|
const exceptions = (context.options[0] || {}).exceptions || [];
|
|
|
|
/**
|
|
* Reports the Reflect violation based on the `existing` and `substitute`
|
|
* @param {Object} node The node that violates the rule.
|
|
* @param {string} existing The existing method name that has been used.
|
|
* @param {string} substitute The Reflect substitute that should be used.
|
|
* @returns {void}
|
|
*/
|
|
function report(node, existing, substitute) {
|
|
context.report({
|
|
node,
|
|
messageId: "preferReflect",
|
|
data: {
|
|
existing,
|
|
substitute,
|
|
},
|
|
});
|
|
}
|
|
|
|
return {
|
|
CallExpression(node) {
|
|
const methodName = (node.callee.property || {}).name;
|
|
const isReflectCall =
|
|
(node.callee.object || {}).name === "Reflect";
|
|
const hasReflectSubstitute = Object.hasOwn(
|
|
reflectSubstitutes,
|
|
methodName,
|
|
);
|
|
const userConfiguredException = exceptions.includes(methodName);
|
|
|
|
if (
|
|
hasReflectSubstitute &&
|
|
!isReflectCall &&
|
|
!userConfiguredException
|
|
) {
|
|
report(
|
|
node,
|
|
existingNames[methodName],
|
|
reflectSubstitutes[methodName],
|
|
);
|
|
}
|
|
},
|
|
UnaryExpression(node) {
|
|
const isDeleteOperator = node.operator === "delete";
|
|
const targetsIdentifier = node.argument.type === "Identifier";
|
|
const userConfiguredException = exceptions.includes("delete");
|
|
|
|
if (
|
|
isDeleteOperator &&
|
|
!targetsIdentifier &&
|
|
!userConfiguredException
|
|
) {
|
|
report(
|
|
node,
|
|
"the delete keyword",
|
|
"Reflect.deleteProperty",
|
|
);
|
|
}
|
|
},
|
|
};
|
|
},
|
|
};
|