Files
oikos/web/node_modules/eslint/lib/rules/prefer-object-has-own.js
dtoro d4d99a7473
Some checks failed
ci / build-test (push) Has been cancelled
ci / docker-build (push) Has been cancelled
feat: Phase 1 — extract the client (web SPA + desktop) to dtoro/oikos-web
Problem: the hexagonal refactor churns the backend tree for nine more
phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper,
compose/web image) must move to its own repo first so doc/layout
rewrites land once on a backend-only tree.

Change:
- New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/
  (updateURL repointed to oikos-web releases), compose/, own CI (web +
  desktop jobs), own deploy script (CI-green gate, TOCTOU guard,
  version-tagged images, prune-to-3), own webhook receiver on :9798 +
  launchd unit, own compose project publishing the same 8091:80.
- Cutover executed on mac-mini in order: oikos stack's web service
  stopped+removed, oikos-web project brought up on 8091; outer Caddy
  untouched (targets the published port) — serving + Authentik flow +
  /wails 404 quirk verified post-cutover.
- Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI
  workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install
  targets, the compose web service, oikos-web from deploy.sh's fallback
  prune list; wails + go-keyring dropped from go.mod, vendor synced.
- README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now
  point at the new repo; mbse + mascot design docs carry a path note.

Risk: production SPA serving depends on the new pipeline now; rollback
is versioned-image re-up of the old web service from a pre-split
checkout (port 8091). Desktop builds installed before the split still
check dtoro/oikos releases — one manual reinstall, noted in the
oikos-web release notes.

Verification: go vet, make test (race), make generate-check, golangci
(no new findings; baseline down 400→365); post-cutover curls —
localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
2026-08-15 22:27:52 +02:00

149 lines
3.7 KiB
JavaScript

/**
* @fileoverview Prefers Object.hasOwn() instead of Object.prototype.hasOwnProperty.call()
* @author Nitin Kumar
* @author Gautam Arora
*/
"use strict";
//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------
const astUtils = require("./utils/ast-utils");
//------------------------------------------------------------------------------
// Helpers
//------------------------------------------------------------------------------
/**
* Checks if the given node is considered to be an access to a property of `Object.prototype`.
* @param {ASTNode} node `MemberExpression` node to evaluate.
* @returns {boolean} `true` if `node.object` is `Object`, `Object.prototype`, or `{}` (empty 'ObjectExpression' node).
*/
function hasLeftHandObject(node) {
/*
* ({}).hasOwnProperty.call(obj, prop) - `true`
* ({ foo }.hasOwnProperty.call(obj, prop)) - `false`, object literal should be empty
*/
if (
node.object.type === "ObjectExpression" &&
node.object.properties.length === 0
) {
return true;
}
const objectNodeToCheck =
node.object.type === "MemberExpression" &&
astUtils.getStaticPropertyName(node.object) === "prototype"
? node.object.object
: node.object;
if (
objectNodeToCheck.type === "Identifier" &&
objectNodeToCheck.name === "Object"
) {
return true;
}
return false;
}
//------------------------------------------------------------------------------
// Rule Definition
//------------------------------------------------------------------------------
/** @type {import('../types').Rule.RuleModule} */
module.exports = {
meta: {
type: "suggestion",
docs: {
description:
"Disallow use of `Object.prototype.hasOwnProperty.call()` and prefer use of `Object.hasOwn()`",
recommended: false,
url: "https://eslint.org/docs/latest/rules/prefer-object-has-own",
},
schema: [],
messages: {
useHasOwn:
"Use 'Object.hasOwn()' instead of 'Object.prototype.hasOwnProperty.call()'.",
},
fixable: "code",
},
create(context) {
const sourceCode = context.sourceCode;
return {
CallExpression(node) {
if (
!(
node.callee.type === "MemberExpression" &&
node.callee.object.type === "MemberExpression"
)
) {
return;
}
const calleePropertyName = astUtils.getStaticPropertyName(
node.callee,
);
const objectPropertyName = astUtils.getStaticPropertyName(
node.callee.object,
);
const isObject = hasLeftHandObject(node.callee.object);
// check `Object` scope
const scope = sourceCode.getScope(node);
const variable = astUtils.getVariableByName(scope, "Object");
if (
calleePropertyName === "call" &&
objectPropertyName === "hasOwnProperty" &&
isObject &&
variable &&
variable.scope.type === "global"
) {
context.report({
node,
messageId: "useHasOwn",
fix(fixer) {
if (
sourceCode.getCommentsInside(node.callee)
.length > 0
) {
return null;
}
const tokenJustBeforeNode =
sourceCode.getTokenBefore(node.callee, {
includeComments: true,
});
// for https://github.com/eslint/eslint/pull/15346#issuecomment-991417335
if (
tokenJustBeforeNode &&
tokenJustBeforeNode.range[1] ===
node.callee.range[0] &&
!astUtils.canTokensBeAdjacent(
tokenJustBeforeNode,
"Object.hasOwn",
)
) {
return fixer.replaceText(
node.callee,
" Object.hasOwn",
);
}
return fixer.replaceText(
node.callee,
"Object.hasOwn",
);
},
});
}
},
};
},
};