Problem: the hexagonal refactor churns the backend tree for nine more phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper, compose/web image) must move to its own repo first so doc/layout rewrites land once on a backend-only tree. Change: - New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/ (updateURL repointed to oikos-web releases), compose/, own CI (web + desktop jobs), own deploy script (CI-green gate, TOCTOU guard, version-tagged images, prune-to-3), own webhook receiver on :9798 + launchd unit, own compose project publishing the same 8091:80. - Cutover executed on mac-mini in order: oikos stack's web service stopped+removed, oikos-web project brought up on 8091; outer Caddy untouched (targets the published port) — serving + Authentik flow + /wails 404 quirk verified post-cutover. - Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install targets, the compose web service, oikos-web from deploy.sh's fallback prune list; wails + go-keyring dropped from go.mod, vendor synced. - README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now point at the new repo; mbse + mascot design docs carry a path note. Risk: production SPA serving depends on the new pipeline now; rollback is versioned-image re-up of the old web service from a pre-split checkout (port 8091). Desktop builds installed before the split still check dtoro/oikos releases — one manual reinstall, noted in the oikos-web release notes. Verification: go vet, make test (race), make generate-check, golangci (no new findings; baseline down 400→365); post-cutover curls — localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
148 lines
3.1 KiB
JavaScript
148 lines
3.1 KiB
JavaScript
/**
|
|
* @fileoverview Rule to enforce declarations in program or function body root.
|
|
* @author Brandon Mills
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
const validParent = new Set([
|
|
"Program",
|
|
"StaticBlock",
|
|
"ExportNamedDeclaration",
|
|
"ExportDefaultDeclaration",
|
|
]);
|
|
const validBlockStatementParent = new Set([
|
|
"FunctionDeclaration",
|
|
"FunctionExpression",
|
|
"ArrowFunctionExpression",
|
|
]);
|
|
|
|
/**
|
|
* Finds the nearest enclosing context where this rule allows declarations and returns its description.
|
|
* @param {ASTNode} node Node to search from.
|
|
* @returns {string} Description. One of "program", "function body", "class static block body".
|
|
*/
|
|
function getAllowedBodyDescription(node) {
|
|
let { parent } = node;
|
|
|
|
while (parent) {
|
|
if (parent.type === "StaticBlock") {
|
|
return "class static block body";
|
|
}
|
|
|
|
if (astUtils.isFunction(parent)) {
|
|
return "function body";
|
|
}
|
|
|
|
({ parent } = parent);
|
|
}
|
|
|
|
return "program";
|
|
}
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "problem",
|
|
|
|
defaultOptions: ["functions", { blockScopedFunctions: "allow" }],
|
|
|
|
docs: {
|
|
description:
|
|
"Disallow variable or `function` declarations in nested blocks",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/no-inner-declarations",
|
|
},
|
|
|
|
schema: [
|
|
{
|
|
enum: ["functions", "both"],
|
|
},
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
blockScopedFunctions: {
|
|
enum: ["allow", "disallow"],
|
|
},
|
|
},
|
|
additionalProperties: false,
|
|
},
|
|
],
|
|
|
|
messages: {
|
|
moveDeclToRoot: "Move {{type}} declaration to {{body}} root.",
|
|
},
|
|
},
|
|
|
|
create(context) {
|
|
const both = context.options[0] === "both";
|
|
const { blockScopedFunctions } = context.options[1];
|
|
|
|
const sourceCode = context.sourceCode;
|
|
const ecmaVersion = context.languageOptions.ecmaVersion;
|
|
|
|
/**
|
|
* Ensure that a given node is at a program or function body's root.
|
|
* @param {ASTNode} node Declaration node to check.
|
|
* @returns {void}
|
|
*/
|
|
function check(node) {
|
|
const parent = node.parent;
|
|
|
|
if (
|
|
parent.type === "BlockStatement" &&
|
|
validBlockStatementParent.has(parent.parent.type)
|
|
) {
|
|
return;
|
|
}
|
|
|
|
if (validParent.has(parent.type)) {
|
|
return;
|
|
}
|
|
|
|
context.report({
|
|
node,
|
|
messageId: "moveDeclToRoot",
|
|
data: {
|
|
type:
|
|
node.type === "FunctionDeclaration"
|
|
? "function"
|
|
: "variable",
|
|
body: getAllowedBodyDescription(node),
|
|
},
|
|
});
|
|
}
|
|
|
|
return {
|
|
FunctionDeclaration(node) {
|
|
const isInStrictCode = sourceCode.getScope(node).upper.isStrict;
|
|
|
|
if (
|
|
blockScopedFunctions === "allow" &&
|
|
ecmaVersion >= 2015 &&
|
|
isInStrictCode
|
|
) {
|
|
return;
|
|
}
|
|
|
|
check(node);
|
|
},
|
|
VariableDeclaration(node) {
|
|
if (both && node.kind === "var") {
|
|
check(node);
|
|
}
|
|
},
|
|
};
|
|
},
|
|
};
|