Problem: the hexagonal refactor churns the backend tree for nine more phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper, compose/web image) must move to its own repo first so doc/layout rewrites land once on a backend-only tree. Change: - New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/ (updateURL repointed to oikos-web releases), compose/, own CI (web + desktop jobs), own deploy script (CI-green gate, TOCTOU guard, version-tagged images, prune-to-3), own webhook receiver on :9798 + launchd unit, own compose project publishing the same 8091:80. - Cutover executed on mac-mini in order: oikos stack's web service stopped+removed, oikos-web project brought up on 8091; outer Caddy untouched (targets the published port) — serving + Authentik flow + /wails 404 quirk verified post-cutover. - Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install targets, the compose web service, oikos-web from deploy.sh's fallback prune list; wails + go-keyring dropped from go.mod, vendor synced. - README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now point at the new repo; mbse + mascot design docs carry a path note. Risk: production SPA serving depends on the new pipeline now; rollback is versioned-image re-up of the old web service from a pre-split checkout (port 8091). Desktop builds installed before the split still check dtoro/oikos releases — one manual reinstall, noted in the oikos-web release notes. Verification: go vet, make test (race), make generate-check, golangci (no new findings; baseline down 400→365); post-cutover curls — localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
167 lines
4.1 KiB
JavaScript
167 lines
4.1 KiB
JavaScript
/**
|
|
* @fileoverview Rule to enforce line breaks between arguments of a function call
|
|
* @author Alexey Gonchar <https://github.com/finico>
|
|
* @deprecated in ESLint v8.53.0
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
deprecated: {
|
|
message: "Formatting rules are being moved out of ESLint core.",
|
|
url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
|
|
deprecatedSince: "8.53.0",
|
|
availableUntil: "11.0.0",
|
|
replacedBy: [
|
|
{
|
|
message:
|
|
"ESLint Stylistic now maintains deprecated stylistic core rules.",
|
|
url: "https://eslint.style/guide/migration",
|
|
plugin: {
|
|
name: "@stylistic/eslint-plugin",
|
|
url: "https://eslint.style",
|
|
},
|
|
rule: {
|
|
name: "function-call-argument-newline",
|
|
url: "https://eslint.style/rules/function-call-argument-newline",
|
|
},
|
|
},
|
|
],
|
|
},
|
|
type: "layout",
|
|
|
|
docs: {
|
|
description:
|
|
"Enforce line breaks between arguments of a function call",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/function-call-argument-newline",
|
|
},
|
|
|
|
fixable: "whitespace",
|
|
|
|
schema: [
|
|
{
|
|
enum: ["always", "never", "consistent"],
|
|
},
|
|
],
|
|
|
|
messages: {
|
|
unexpectedLineBreak: "There should be no line break here.",
|
|
missingLineBreak:
|
|
"There should be a line break after this argument.",
|
|
},
|
|
},
|
|
|
|
create(context) {
|
|
const sourceCode = context.sourceCode;
|
|
|
|
const checkers = {
|
|
unexpected: {
|
|
messageId: "unexpectedLineBreak",
|
|
check: (prevToken, currentToken) =>
|
|
prevToken.loc.end.line !== currentToken.loc.start.line,
|
|
createFix: (token, tokenBefore) => fixer =>
|
|
fixer.replaceTextRange(
|
|
[tokenBefore.range[1], token.range[0]],
|
|
" ",
|
|
),
|
|
},
|
|
missing: {
|
|
messageId: "missingLineBreak",
|
|
check: (prevToken, currentToken) =>
|
|
prevToken.loc.end.line === currentToken.loc.start.line,
|
|
createFix: (token, tokenBefore) => fixer =>
|
|
fixer.replaceTextRange(
|
|
[tokenBefore.range[1], token.range[0]],
|
|
"\n",
|
|
),
|
|
},
|
|
};
|
|
|
|
/**
|
|
* Check all arguments for line breaks in the CallExpression
|
|
* @param {CallExpression} node node to evaluate
|
|
* @param {{ messageId: string, check: Function }} checker selected checker
|
|
* @returns {void}
|
|
* @private
|
|
*/
|
|
function checkArguments(node, checker) {
|
|
for (let i = 1; i < node.arguments.length; i++) {
|
|
const prevArgToken = sourceCode.getLastToken(
|
|
node.arguments[i - 1],
|
|
);
|
|
const currentArgToken = sourceCode.getFirstToken(
|
|
node.arguments[i],
|
|
);
|
|
|
|
if (checker.check(prevArgToken, currentArgToken)) {
|
|
const tokenBefore = sourceCode.getTokenBefore(
|
|
currentArgToken,
|
|
{ includeComments: true },
|
|
);
|
|
|
|
const hasLineCommentBefore = tokenBefore.type === "Line";
|
|
|
|
context.report({
|
|
node,
|
|
loc: {
|
|
start: tokenBefore.loc.end,
|
|
end: currentArgToken.loc.start,
|
|
},
|
|
messageId: checker.messageId,
|
|
fix: hasLineCommentBefore
|
|
? null
|
|
: checker.createFix(currentArgToken, tokenBefore),
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Check if open space is present in a function name
|
|
* @param {CallExpression} node node to evaluate
|
|
* @returns {void}
|
|
* @private
|
|
*/
|
|
function check(node) {
|
|
if (node.arguments.length < 2) {
|
|
return;
|
|
}
|
|
|
|
const option = context.options[0] || "always";
|
|
|
|
if (option === "never") {
|
|
checkArguments(node, checkers.unexpected);
|
|
} else if (option === "always") {
|
|
checkArguments(node, checkers.missing);
|
|
} else if (option === "consistent") {
|
|
const firstArgToken = sourceCode.getLastToken(
|
|
node.arguments[0],
|
|
);
|
|
const secondArgToken = sourceCode.getFirstToken(
|
|
node.arguments[1],
|
|
);
|
|
|
|
if (
|
|
firstArgToken.loc.end.line === secondArgToken.loc.start.line
|
|
) {
|
|
checkArguments(node, checkers.unexpected);
|
|
} else {
|
|
checkArguments(node, checkers.missing);
|
|
}
|
|
}
|
|
}
|
|
|
|
return {
|
|
CallExpression: check,
|
|
NewExpression: check,
|
|
};
|
|
},
|
|
};
|