Problem: the hexagonal refactor churns the backend tree for nine more phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper, compose/web image) must move to its own repo first so doc/layout rewrites land once on a backend-only tree. Change: - New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/ (updateURL repointed to oikos-web releases), compose/, own CI (web + desktop jobs), own deploy script (CI-green gate, TOCTOU guard, version-tagged images, prune-to-3), own webhook receiver on :9798 + launchd unit, own compose project publishing the same 8091:80. - Cutover executed on mac-mini in order: oikos stack's web service stopped+removed, oikos-web project brought up on 8091; outer Caddy untouched (targets the published port) — serving + Authentik flow + /wails 404 quirk verified post-cutover. - Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install targets, the compose web service, oikos-web from deploy.sh's fallback prune list; wails + go-keyring dropped from go.mod, vendor synced. - README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now point at the new repo; mbse + mascot design docs carry a path note. Risk: production SPA serving depends on the new pipeline now; rollback is versioned-image re-up of the old web service from a pre-split checkout (port 8091). Desktop builds installed before the split still check dtoro/oikos releases — one manual reinstall, noted in the oikos-web release notes. Verification: go vet, make test (race), make generate-check, golangci (no new findings; baseline down 400→365); post-cutover curls — localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
202 lines
5.1 KiB
JavaScript
202 lines
5.1 KiB
JavaScript
/**
|
|
* @fileoverview Counts the cyclomatic complexity of each function of the script. See http://en.wikipedia.org/wiki/Cyclomatic_complexity.
|
|
* Counts the number of if, conditional, for, while, try, switch/case,
|
|
* @author Patrick Brosset
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
const { upperCaseFirst } = require("../shared/string-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
const THRESHOLD_DEFAULT = 20;
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
defaultOptions: [THRESHOLD_DEFAULT],
|
|
|
|
docs: {
|
|
description:
|
|
"Enforce a maximum cyclomatic complexity allowed in a program",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/complexity",
|
|
},
|
|
|
|
schema: [
|
|
{
|
|
oneOf: [
|
|
{
|
|
type: "integer",
|
|
minimum: 0,
|
|
},
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
maximum: {
|
|
type: "integer",
|
|
minimum: 0,
|
|
},
|
|
max: {
|
|
type: "integer",
|
|
minimum: 0,
|
|
},
|
|
variant: {
|
|
enum: ["classic", "modified"],
|
|
},
|
|
},
|
|
additionalProperties: false,
|
|
},
|
|
],
|
|
},
|
|
],
|
|
|
|
messages: {
|
|
complex:
|
|
"{{name}} has a complexity of {{complexity}}. Maximum allowed is {{max}}.",
|
|
},
|
|
},
|
|
|
|
create(context) {
|
|
const sourceCode = context.sourceCode;
|
|
const option = context.options[0];
|
|
let threshold = THRESHOLD_DEFAULT;
|
|
let VARIANT = "classic";
|
|
|
|
if (typeof option === "object") {
|
|
if (
|
|
Object.hasOwn(option, "maximum") ||
|
|
Object.hasOwn(option, "max")
|
|
) {
|
|
threshold = option.maximum || option.max;
|
|
}
|
|
|
|
if (Object.hasOwn(option, "variant")) {
|
|
VARIANT = option.variant;
|
|
}
|
|
} else if (typeof option === "number") {
|
|
threshold = option;
|
|
}
|
|
|
|
const IS_MODIFIED_COMPLEXITY = VARIANT === "modified";
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Helpers
|
|
//--------------------------------------------------------------------------
|
|
|
|
// Using a stack to store complexity per code path
|
|
const complexities = [];
|
|
|
|
/**
|
|
* Increase the complexity of the code path in context
|
|
* @returns {void}
|
|
* @private
|
|
*/
|
|
function increaseComplexity() {
|
|
complexities[complexities.length - 1]++;
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public API
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
onCodePathStart() {
|
|
// The initial complexity is 1, representing one execution path in the CodePath
|
|
complexities.push(1);
|
|
},
|
|
|
|
// Each branching in the code adds 1 to the complexity
|
|
CatchClause: increaseComplexity,
|
|
ConditionalExpression: increaseComplexity,
|
|
LogicalExpression: increaseComplexity,
|
|
ForStatement: increaseComplexity,
|
|
ForInStatement: increaseComplexity,
|
|
ForOfStatement: increaseComplexity,
|
|
IfStatement: increaseComplexity,
|
|
WhileStatement: increaseComplexity,
|
|
DoWhileStatement: increaseComplexity,
|
|
AssignmentPattern: increaseComplexity,
|
|
|
|
// Avoid `default`
|
|
"SwitchCase[test]": () =>
|
|
IS_MODIFIED_COMPLEXITY || increaseComplexity(),
|
|
SwitchStatement: () =>
|
|
IS_MODIFIED_COMPLEXITY && increaseComplexity(),
|
|
|
|
// Logical assignment operators have short-circuiting behavior
|
|
AssignmentExpression(node) {
|
|
if (astUtils.isLogicalAssignmentOperator(node.operator)) {
|
|
increaseComplexity();
|
|
}
|
|
},
|
|
|
|
MemberExpression(node) {
|
|
if (node.optional === true) {
|
|
increaseComplexity();
|
|
}
|
|
},
|
|
|
|
CallExpression(node) {
|
|
if (node.optional === true) {
|
|
increaseComplexity();
|
|
}
|
|
},
|
|
|
|
onCodePathEnd(codePath, node) {
|
|
const complexity = complexities.pop();
|
|
|
|
/*
|
|
* This rule only evaluates complexity of functions, so "program" is excluded.
|
|
* Class field initializers and class static blocks are implicit functions. Therefore,
|
|
* they shouldn't contribute to the enclosing function's complexity, but their
|
|
* own complexity should be evaluated.
|
|
*/
|
|
if (
|
|
codePath.origin !== "function" &&
|
|
codePath.origin !== "class-field-initializer" &&
|
|
codePath.origin !== "class-static-block"
|
|
) {
|
|
return;
|
|
}
|
|
|
|
if (complexity > threshold) {
|
|
let name;
|
|
let loc = node.loc;
|
|
|
|
if (codePath.origin === "class-field-initializer") {
|
|
name = "class field initializer";
|
|
} else if (codePath.origin === "class-static-block") {
|
|
name = "class static block";
|
|
loc = sourceCode.getFirstToken(node).loc;
|
|
} else {
|
|
name = astUtils.getFunctionNameWithKind(node);
|
|
loc = astUtils.getFunctionHeadLoc(node, sourceCode);
|
|
}
|
|
|
|
context.report({
|
|
node,
|
|
loc,
|
|
messageId: "complex",
|
|
data: {
|
|
name: upperCaseFirst(name),
|
|
complexity,
|
|
max: threshold,
|
|
},
|
|
});
|
|
}
|
|
},
|
|
};
|
|
},
|
|
};
|