Files
oikos/web/node_modules/eslint-plugin-svelte/lib/rules/no-goto-without-base.js
dtoro d4d99a7473
Some checks failed
ci / build-test (push) Has been cancelled
ci / docker-build (push) Has been cancelled
feat: Phase 1 — extract the client (web SPA + desktop) to dtoro/oikos-web
Problem: the hexagonal refactor churns the backend tree for nine more
phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper,
compose/web image) must move to its own repo first so doc/layout
rewrites land once on a backend-only tree.

Change:
- New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/
  (updateURL repointed to oikos-web releases), compose/, own CI (web +
  desktop jobs), own deploy script (CI-green gate, TOCTOU guard,
  version-tagged images, prune-to-3), own webhook receiver on :9798 +
  launchd unit, own compose project publishing the same 8091:80.
- Cutover executed on mac-mini in order: oikos stack's web service
  stopped+removed, oikos-web project brought up on 8091; outer Caddy
  untouched (targets the published port) — serving + Authentik flow +
  /wails 404 quirk verified post-cutover.
- Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI
  workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install
  targets, the compose web service, oikos-web from deploy.sh's fallback
  prune list; wails + go-keyring dropped from go.mod, vendor synced.
- README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now
  point at the new repo; mbse + mascot design docs carry a path note.

Risk: production SPA serving depends on the new pipeline now; rollback
is versioned-image re-up of the old web service from a pre-split
checkout (port 8091). Desktop builds installed before the split still
check dtoro/oikos releases — one manual reinstall, noted in the
oikos-web release notes.

Verification: go vet, make test (race), make generate-check, golangci
(no new findings; baseline down 400→365); post-cutover curls —
localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
2026-08-15 22:27:52 +02:00

109 lines
4.2 KiB
JavaScript

"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
const utils_1 = require("../utils");
const eslint_utils_1 = require("@eslint-community/eslint-utils");
const compat_1 = require("../utils/compat");
const ast_utils_1 = require("../utils/ast-utils");
exports.default = (0, utils_1.createRule)('no-goto-without-base', {
meta: {
docs: {
description: 'disallow using goto() without the base path',
category: 'SvelteKit',
recommended: false
},
schema: [],
messages: {
isNotPrefixedWithBasePath: "Found a goto() call with a url that isn't prefixed with the base path."
},
type: 'suggestion'
},
create(context) {
return {
Program() {
const referenceTracker = new eslint_utils_1.ReferenceTracker((0, compat_1.getSourceCode)(context).scopeManager.globalScope);
const basePathNames = extractBasePathReferences(referenceTracker, context);
for (const gotoCall of extractGotoReferences(referenceTracker)) {
if (gotoCall.arguments.length < 1) {
continue;
}
const path = gotoCall.arguments[0];
switch (path.type) {
case 'BinaryExpression':
checkBinaryExpression(context, path, basePathNames);
break;
case 'Literal':
checkLiteral(context, path);
break;
case 'TemplateLiteral':
checkTemplateLiteral(context, path, basePathNames);
break;
default:
context.report({ loc: path.loc, messageId: 'isNotPrefixedWithBasePath' });
}
}
}
};
}
});
function checkBinaryExpression(context, path, basePathNames) {
if (path.left.type !== 'Identifier' || !basePathNames.has(path.left)) {
context.report({ loc: path.loc, messageId: 'isNotPrefixedWithBasePath' });
}
}
function checkTemplateLiteral(context, path, basePathNames) {
const startingIdentifier = extractStartingIdentifier(path);
if (startingIdentifier === undefined || !basePathNames.has(startingIdentifier)) {
context.report({ loc: path.loc, messageId: 'isNotPrefixedWithBasePath' });
}
}
function checkLiteral(context, path) {
const absolutePathRegex = /^(?:[+a-z]+:)?\/\//i;
if (!absolutePathRegex.test(path.value?.toString() ?? '')) {
context.report({ loc: path.loc, messageId: 'isNotPrefixedWithBasePath' });
}
}
function extractStartingIdentifier(templateLiteral) {
const literalParts = [...templateLiteral.expressions, ...templateLiteral.quasis].sort((a, b) => a.range[0] < b.range[0] ? -1 : 1);
for (const part of literalParts) {
if (part.type === 'TemplateElement' && part.value.raw === '') {
// Skip empty quasi in the begining
continue;
}
if (part.type === 'Identifier') {
return part;
}
return undefined;
}
return undefined;
}
function extractGotoReferences(referenceTracker) {
return Array.from(referenceTracker.iterateEsmReferences({
'$app/navigation': {
[eslint_utils_1.ReferenceTracker.ESM]: true,
goto: {
[eslint_utils_1.ReferenceTracker.CALL]: true
}
}
}), ({ node }) => node);
}
function extractBasePathReferences(referenceTracker, context) {
const set = new Set();
for (const { node } of referenceTracker.iterateEsmReferences({
'$app/paths': {
[eslint_utils_1.ReferenceTracker.ESM]: true,
base: {
[eslint_utils_1.ReferenceTracker.READ]: true
}
}
})) {
const variable = (0, ast_utils_1.findVariable)(context, node.local);
if (!variable)
continue;
for (const reference of variable.references) {
if (reference.identifier.type === 'Identifier')
set.add(reference.identifier);
}
}
return set;
}