dtoro
e074f04bdf
Problem: the hexagonal-architecture plan (plans/2026-08-15-hexagonal-
architecture.md) needs its foundation — an accepted ADR, the target
directory tree, and machine-checked dependency rules — before any
service extraction starts. Also folds the four outstanding review
findings (F3.1/F5/F6/F7) into the plan: ObservationService owns the
bounded probe-concurrency contract (scheduler.go:133), Phase 9 gates
ExecutionService+PolicyService ≥ 90% with a gating-matrix test,
per-phase abort criteria, and the §3.2 internal/config note.
Change:
- docs/adr/0016-hexagonal-ports-adapters.md records context, decision,
and consequences of the ports & adapters migration.
- internal/domain → internal/core/domain (mechanical import rewrite,
20 files), new internal/core/{ports,app}, internal/adapters trees
with package docs.
- .golangci.yml: depguard rules for §3.1 (core purity, no agent-client
tech in core, nomos isolation — the nomos rules self-activate when
internal/nomos exists in Phase 8). Config migrated to golangci-lint
v2 format so it loads at all (the v1 config errored under v2, masked
by CI's advisory continue-on-error). Verified depguard fires on a
planted openai-go import in internal/core/app.
- CONTRIBUTING.md layout section now shows the core/adapters tree.
Risk: import path churn is mechanical and tests pass unchanged; the
lint config migration surfaces the pre-existing 400-issue baseline
(advisory in CI, unchanged policy) — new/moved packages lint clean.
Verification: go vet ./..., make test (race, core/domain at 100%
coverage), make generate-check, golangci-lint on internal/core/... and
internal/adapters/... — 0 issues; depguard violation probe confirmed.
77 lines
1.7 KiB
Go
77 lines
1.7 KiB
Go
package domain
|
|
|
|
import "time"
|
|
|
|
// Feedback records what was learned from an execution.
|
|
type Feedback struct {
|
|
EntityID UUID
|
|
ExecutionID UUID
|
|
Outcome string
|
|
Observation string
|
|
Lesson string
|
|
UnexpectedSideEffects []string
|
|
Tags []string
|
|
CreatedAt time.Time
|
|
}
|
|
|
|
// Feedback outcomes.
|
|
const (
|
|
OutcomeSuccess = "success"
|
|
OutcomeFailure = "failure"
|
|
OutcomePartial = "partial"
|
|
OutcomeUnexpected = "unexpected"
|
|
)
|
|
|
|
// Pattern is a generalized rule extracted from accumulated feedback.
|
|
type Pattern struct {
|
|
EntityID UUID
|
|
AppliesType string
|
|
Action string
|
|
Pattern string
|
|
Confidence float64
|
|
EvidenceCount int
|
|
SuccessCount int
|
|
FailureCount int
|
|
Status string
|
|
Quarantined bool
|
|
Version int
|
|
LastValidatedAt *time.Time
|
|
CreatedAt time.Time
|
|
}
|
|
|
|
// Pattern lifecycle states.
|
|
const (
|
|
PatternHypothesized = "hypothesized"
|
|
PatternValidated = "validated"
|
|
PatternActive = "active"
|
|
PatternDeprecated = "deprecated"
|
|
PatternInvalidated = "invalidated"
|
|
)
|
|
|
|
// Skill is a codified procedure refined through validated patterns.
|
|
type Skill struct {
|
|
EntityID UUID
|
|
Version int
|
|
Name string
|
|
Procedure map[string]any
|
|
AppliesType string
|
|
Action string
|
|
PatternIDs []UUID
|
|
Status string
|
|
SuccessRate float64
|
|
ChangedBy UUID
|
|
ChangeReason string
|
|
LastUsedAt *time.Time
|
|
CreatedAt time.Time
|
|
}
|
|
|
|
// Skill lifecycle states.
|
|
const (
|
|
SkillDrafted = "drafted"
|
|
SkillTested = "tested"
|
|
SkillActive = "active"
|
|
SkillRefined = "refined"
|
|
SkillDeprecated = "deprecated"
|
|
SkillFailed = "failed"
|
|
)
|