Problem: the hexagonal refactor churns the backend tree for nine more phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper, compose/web image) must move to its own repo first so doc/layout rewrites land once on a backend-only tree. Change: - New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/ (updateURL repointed to oikos-web releases), compose/, own CI (web + desktop jobs), own deploy script (CI-green gate, TOCTOU guard, version-tagged images, prune-to-3), own webhook receiver on :9798 + launchd unit, own compose project publishing the same 8091:80. - Cutover executed on mac-mini in order: oikos stack's web service stopped+removed, oikos-web project brought up on 8091; outer Caddy untouched (targets the published port) — serving + Authentik flow + /wails 404 quirk verified post-cutover. - Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install targets, the compose web service, oikos-web from deploy.sh's fallback prune list; wails + go-keyring dropped from go.mod, vendor synced. - README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now point at the new repo; mbse + mascot design docs carry a path note. Risk: production SPA serving depends on the new pipeline now; rollback is versioned-image re-up of the old web service from a pre-split checkout (port 8091). Desktop builds installed before the split still check dtoro/oikos releases — one manual reinstall, noted in the oikos-web release notes. Verification: go vet, make test (race), make generate-check, golangci (no new findings; baseline down 400→365); post-cutover curls — localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
166 lines
4.2 KiB
JavaScript
166 lines
4.2 KiB
JavaScript
/**
|
|
* @fileoverview Rule to enforce var declarations are only at the top of a function.
|
|
* @author Danny Fritz
|
|
* @author Gyandeep Singh
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description:
|
|
"Require `var` declarations be placed at the top of their containing scope",
|
|
recommended: false,
|
|
frozen: true,
|
|
url: "https://eslint.org/docs/latest/rules/vars-on-top",
|
|
},
|
|
|
|
schema: [],
|
|
messages: {
|
|
top: "All 'var' declarations must be at the top of the function scope.",
|
|
},
|
|
},
|
|
|
|
create(context) {
|
|
//--------------------------------------------------------------------------
|
|
// Helpers
|
|
//--------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Has AST suggesting a directive.
|
|
* @param {ASTNode} node any node
|
|
* @returns {boolean} whether the given node structurally represents a directive
|
|
*/
|
|
function looksLikeDirective(node) {
|
|
return (
|
|
node.type === "ExpressionStatement" &&
|
|
node.expression.type === "Literal" &&
|
|
typeof node.expression.value === "string"
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Check to see if its a ES6 import declaration
|
|
* @param {ASTNode} node any node
|
|
* @returns {boolean} whether the given node represents a import declaration
|
|
*/
|
|
function looksLikeImport(node) {
|
|
return (
|
|
node.type === "ImportDeclaration" ||
|
|
node.type === "ImportSpecifier" ||
|
|
node.type === "ImportDefaultSpecifier" ||
|
|
node.type === "ImportNamespaceSpecifier"
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Checks whether a given node is a variable declaration or not.
|
|
* @param {ASTNode} node any node
|
|
* @returns {boolean} `true` if the node is a variable declaration.
|
|
*/
|
|
function isVariableDeclaration(node) {
|
|
return (
|
|
node.type === "VariableDeclaration" ||
|
|
(node.type === "ExportNamedDeclaration" &&
|
|
node.declaration &&
|
|
node.declaration.type === "VariableDeclaration")
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Checks whether this variable is on top of the block body
|
|
* @param {ASTNode} node The node to check
|
|
* @param {ASTNode[]} statements collection of ASTNodes for the parent node block
|
|
* @returns {boolean} True if var is on top otherwise false
|
|
*/
|
|
function isVarOnTop(node, statements) {
|
|
const l = statements.length;
|
|
let i = 0;
|
|
|
|
// Skip over directives and imports. Static blocks don't have either.
|
|
if (node.parent.type !== "StaticBlock") {
|
|
for (; i < l; ++i) {
|
|
if (
|
|
!looksLikeDirective(statements[i]) &&
|
|
!looksLikeImport(statements[i])
|
|
) {
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
for (; i < l; ++i) {
|
|
if (!isVariableDeclaration(statements[i])) {
|
|
return false;
|
|
}
|
|
if (statements[i] === node) {
|
|
return true;
|
|
}
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* Checks whether variable is on top at the global level
|
|
* @param {ASTNode} node The node to check
|
|
* @param {ASTNode} parent Parent of the node
|
|
* @returns {void}
|
|
*/
|
|
function globalVarCheck(node, parent) {
|
|
if (!isVarOnTop(node, parent.body)) {
|
|
context.report({ node, messageId: "top" });
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Checks whether variable is on top at functional block scope level
|
|
* @param {ASTNode} node The node to check
|
|
* @returns {void}
|
|
*/
|
|
function blockScopeVarCheck(node) {
|
|
const { parent } = node;
|
|
|
|
if (
|
|
parent.type === "BlockStatement" &&
|
|
/Function/u.test(parent.parent.type) &&
|
|
isVarOnTop(node, parent.body)
|
|
) {
|
|
return;
|
|
}
|
|
|
|
if (
|
|
parent.type === "StaticBlock" &&
|
|
isVarOnTop(node, parent.body)
|
|
) {
|
|
return;
|
|
}
|
|
|
|
context.report({ node, messageId: "top" });
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public API
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
"VariableDeclaration[kind='var']"(node) {
|
|
if (node.parent.type === "ExportNamedDeclaration") {
|
|
globalVarCheck(node.parent, node.parent.parent);
|
|
} else if (node.parent.type === "Program") {
|
|
globalVarCheck(node, node.parent);
|
|
} else {
|
|
blockScopeVarCheck(node);
|
|
}
|
|
},
|
|
};
|
|
},
|
|
};
|