Problem: the hexagonal refactor churns the backend tree for nine more phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper, compose/web image) must move to its own repo first so doc/layout rewrites land once on a backend-only tree. Change: - New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/ (updateURL repointed to oikos-web releases), compose/, own CI (web + desktop jobs), own deploy script (CI-green gate, TOCTOU guard, version-tagged images, prune-to-3), own webhook receiver on :9798 + launchd unit, own compose project publishing the same 8091:80. - Cutover executed on mac-mini in order: oikos stack's web service stopped+removed, oikos-web project brought up on 8091; outer Caddy untouched (targets the published port) — serving + Authentik flow + /wails 404 quirk verified post-cutover. - Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install targets, the compose web service, oikos-web from deploy.sh's fallback prune list; wails + go-keyring dropped from go.mod, vendor synced. - README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now point at the new repo; mbse + mascot design docs carry a path note. Risk: production SPA serving depends on the new pipeline now; rollback is versioned-image re-up of the old web service from a pre-split checkout (port 8091). Desktop builds installed before the split still check dtoro/oikos releases — one manual reinstall, noted in the oikos-web release notes. Verification: go vet, make test (race), make generate-check, golangci (no new findings; baseline down 400→365); post-cutover curls — localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
96 lines
2.7 KiB
JavaScript
96 lines
2.7 KiB
JavaScript
/**
|
|
* @fileoverview A rule to disallow unnecessary `.call()` and `.apply()`.
|
|
* @author Toru Nagashima
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Helpers
|
|
//------------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Checks whether or not a node is a `.call()`/`.apply()`.
|
|
* @param {ASTNode} node A CallExpression node to check.
|
|
* @returns {boolean} Whether or not the node is a `.call()`/`.apply()`.
|
|
*/
|
|
function isCallOrNonVariadicApply(node) {
|
|
const callee = astUtils.skipChainExpression(node.callee);
|
|
|
|
return (
|
|
callee.type === "MemberExpression" &&
|
|
callee.property.type === "Identifier" &&
|
|
callee.computed === false &&
|
|
((callee.property.name === "call" && node.arguments.length >= 1) ||
|
|
(callee.property.name === "apply" &&
|
|
node.arguments.length === 2 &&
|
|
node.arguments[1].type === "ArrayExpression"))
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Checks whether or not `thisArg` is not changed by `.call()`/`.apply()`.
|
|
* @param {ASTNode|null} expectedThis The node that is the owner of the applied function.
|
|
* @param {ASTNode} thisArg The node that is given to the first argument of the `.call()`/`.apply()`.
|
|
* @param {SourceCode} sourceCode The ESLint source code object.
|
|
* @returns {boolean} Whether or not `thisArg` is not changed by `.call()`/`.apply()`.
|
|
*/
|
|
function isValidThisArg(expectedThis, thisArg, sourceCode) {
|
|
if (!expectedThis) {
|
|
return astUtils.isNullOrUndefined(thisArg);
|
|
}
|
|
return astUtils.equalTokens(expectedThis, thisArg, sourceCode);
|
|
}
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description:
|
|
"Disallow unnecessary calls to `.call()` and `.apply()`",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/no-useless-call",
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
unnecessaryCall: "Unnecessary '.{{name}}()'.",
|
|
},
|
|
},
|
|
|
|
create(context) {
|
|
const sourceCode = context.sourceCode;
|
|
|
|
return {
|
|
CallExpression(node) {
|
|
if (!isCallOrNonVariadicApply(node)) {
|
|
return;
|
|
}
|
|
|
|
const callee = astUtils.skipChainExpression(node.callee);
|
|
const applied = astUtils.skipChainExpression(callee.object);
|
|
const expectedThis =
|
|
applied.type === "MemberExpression" ? applied.object : null;
|
|
const thisArg = node.arguments[0];
|
|
|
|
if (isValidThisArg(expectedThis, thisArg, sourceCode)) {
|
|
context.report({
|
|
node,
|
|
messageId: "unnecessaryCall",
|
|
data: { name: callee.property.name },
|
|
});
|
|
}
|
|
},
|
|
};
|
|
},
|
|
};
|