Problem: the hexagonal refactor churns the backend tree for nine more phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper, compose/web image) must move to its own repo first so doc/layout rewrites land once on a backend-only tree. Change: - New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/ (updateURL repointed to oikos-web releases), compose/, own CI (web + desktop jobs), own deploy script (CI-green gate, TOCTOU guard, version-tagged images, prune-to-3), own webhook receiver on :9798 + launchd unit, own compose project publishing the same 8091:80. - Cutover executed on mac-mini in order: oikos stack's web service stopped+removed, oikos-web project brought up on 8091; outer Caddy untouched (targets the published port) — serving + Authentik flow + /wails 404 quirk verified post-cutover. - Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install targets, the compose web service, oikos-web from deploy.sh's fallback prune list; wails + go-keyring dropped from go.mod, vendor synced. - README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now point at the new repo; mbse + mascot design docs carry a path note. Risk: production SPA serving depends on the new pipeline now; rollback is versioned-image re-up of the old web service from a pre-split checkout (port 8091). Desktop builds installed before the split still check dtoro/oikos releases — one manual reinstall, noted in the oikos-web release notes. Verification: go vet, make test (race), make generate-check, golangci (no new findings; baseline down 400→365); post-cutover curls — localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
114 lines
2.6 KiB
JavaScript
114 lines
2.6 KiB
JavaScript
/**
|
|
* @fileoverview Disallow shadowing of globalThis, NaN, undefined, and Infinity (ES2020 section 18.1)
|
|
* @author Michael Ficarra
|
|
*/
|
|
"use strict";
|
|
|
|
/**
|
|
* Determines if a variable safely shadows undefined.
|
|
* This is the case when a variable named `undefined` is never assigned to a value (i.e. it always shares the same value
|
|
* as the global).
|
|
* @param {eslintScope.Variable} variable The variable to check
|
|
* @returns {boolean} true if this variable safely shadows `undefined`
|
|
*/
|
|
function safelyShadowsUndefined(variable) {
|
|
return (
|
|
variable.name === "undefined" &&
|
|
variable.references.every(ref => !ref.isWrite()) &&
|
|
variable.defs.every(
|
|
def =>
|
|
def.node.type === "VariableDeclarator" &&
|
|
def.node.init === null,
|
|
)
|
|
);
|
|
}
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
defaultOptions: [
|
|
{
|
|
reportGlobalThis: false,
|
|
},
|
|
],
|
|
|
|
docs: {
|
|
description: "Disallow identifiers from shadowing restricted names",
|
|
recommended: true,
|
|
url: "https://eslint.org/docs/latest/rules/no-shadow-restricted-names",
|
|
},
|
|
|
|
schema: [
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
reportGlobalThis: {
|
|
type: "boolean",
|
|
},
|
|
},
|
|
additionalProperties: false,
|
|
},
|
|
],
|
|
|
|
messages: {
|
|
shadowingRestrictedName: "Shadowing of global property '{{name}}'.",
|
|
},
|
|
},
|
|
|
|
create(context) {
|
|
const [{ reportGlobalThis }] = context.options;
|
|
|
|
const RESTRICTED = new Set([
|
|
"undefined",
|
|
"NaN",
|
|
"Infinity",
|
|
"arguments",
|
|
"eval",
|
|
]);
|
|
|
|
if (reportGlobalThis) {
|
|
RESTRICTED.add("globalThis");
|
|
}
|
|
|
|
const sourceCode = context.sourceCode;
|
|
|
|
// Track reported nodes to avoid duplicate reports. For example, on class declarations.
|
|
const reportedNodes = new Set();
|
|
|
|
return {
|
|
"VariableDeclaration, :function, CatchClause, ImportDeclaration, ClassDeclaration, ClassExpression"(
|
|
node,
|
|
) {
|
|
for (const variable of sourceCode.getDeclaredVariables(node)) {
|
|
if (
|
|
variable.defs.length > 0 &&
|
|
RESTRICTED.has(variable.name) &&
|
|
!safelyShadowsUndefined(variable)
|
|
) {
|
|
for (const def of variable.defs) {
|
|
const nodeToReport = def.name;
|
|
|
|
if (!reportedNodes.has(nodeToReport)) {
|
|
reportedNodes.add(nodeToReport);
|
|
context.report({
|
|
node: nodeToReport,
|
|
messageId: "shadowingRestrictedName",
|
|
data: {
|
|
name: variable.name,
|
|
},
|
|
});
|
|
}
|
|
}
|
|
}
|
|
}
|
|
},
|
|
};
|
|
},
|
|
};
|