Problem: the hexagonal refactor churns the backend tree for nine more phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper, compose/web image) must move to its own repo first so doc/layout rewrites land once on a backend-only tree. Change: - New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/ (updateURL repointed to oikos-web releases), compose/, own CI (web + desktop jobs), own deploy script (CI-green gate, TOCTOU guard, version-tagged images, prune-to-3), own webhook receiver on :9798 + launchd unit, own compose project publishing the same 8091:80. - Cutover executed on mac-mini in order: oikos stack's web service stopped+removed, oikos-web project brought up on 8091; outer Caddy untouched (targets the published port) — serving + Authentik flow + /wails 404 quirk verified post-cutover. - Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install targets, the compose web service, oikos-web from deploy.sh's fallback prune list; wails + go-keyring dropped from go.mod, vendor synced. - README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now point at the new repo; mbse + mascot design docs carry a path note. Risk: production SPA serving depends on the new pipeline now; rollback is versioned-image re-up of the old web service from a pre-split checkout (port 8091). Desktop builds installed before the split still check dtoro/oikos releases — one manual reinstall, noted in the oikos-web release notes. Verification: go vet, make test (race), make generate-check, golangci (no new findings; baseline down 400→365); post-cutover curls — localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
125 lines
2.9 KiB
JavaScript
125 lines
2.9 KiB
JavaScript
/**
|
|
* @fileoverview Rule to disallow calls to the `Object` constructor without an argument
|
|
* @author Francesco Trotta
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const {
|
|
getVariableByName,
|
|
isArrowToken,
|
|
isStartOfExpressionStatement,
|
|
needsPrecedingSemicolon,
|
|
} = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description:
|
|
"Disallow calls to the `Object` constructor without an argument",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/no-object-constructor",
|
|
},
|
|
|
|
hasSuggestions: true,
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
preferLiteral: "The object literal notation {} is preferable.",
|
|
useLiteral: "Replace with '{{replacement}}'.",
|
|
useLiteralAfterSemicolon:
|
|
"Replace with '{{replacement}}', add preceding semicolon.",
|
|
},
|
|
},
|
|
|
|
create(context) {
|
|
const sourceCode = context.sourceCode;
|
|
|
|
/**
|
|
* Determines whether or not an object literal that replaces a specified node needs to be enclosed in parentheses.
|
|
* @param {ASTNode} node The node to be replaced.
|
|
* @returns {boolean} Whether or not parentheses around the object literal are required.
|
|
*/
|
|
function needsParentheses(node) {
|
|
if (isStartOfExpressionStatement(node)) {
|
|
return true;
|
|
}
|
|
|
|
const prevToken = sourceCode.getTokenBefore(node);
|
|
|
|
if (prevToken && isArrowToken(prevToken)) {
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* Reports on nodes where the `Object` constructor is called without arguments.
|
|
* @param {ASTNode} node The node to evaluate.
|
|
* @returns {void}
|
|
*/
|
|
function check(node) {
|
|
if (
|
|
node.callee.type !== "Identifier" ||
|
|
node.callee.name !== "Object" ||
|
|
node.arguments.length
|
|
) {
|
|
return;
|
|
}
|
|
|
|
const variable = getVariableByName(
|
|
sourceCode.getScope(node),
|
|
"Object",
|
|
);
|
|
|
|
if (variable && variable.identifiers.length === 0) {
|
|
let replacement;
|
|
let fixText;
|
|
let messageId = "useLiteral";
|
|
|
|
if (needsParentheses(node)) {
|
|
replacement = "({})";
|
|
if (needsPrecedingSemicolon(sourceCode, node)) {
|
|
fixText = ";({})";
|
|
messageId = "useLiteralAfterSemicolon";
|
|
} else {
|
|
fixText = "({})";
|
|
}
|
|
} else {
|
|
replacement = fixText = "{}";
|
|
}
|
|
|
|
context.report({
|
|
node,
|
|
messageId: "preferLiteral",
|
|
suggest: [
|
|
{
|
|
messageId,
|
|
data: { replacement },
|
|
fix: fixer => fixer.replaceText(node, fixText),
|
|
},
|
|
],
|
|
});
|
|
}
|
|
}
|
|
|
|
return {
|
|
CallExpression: check,
|
|
NewExpression: check,
|
|
};
|
|
},
|
|
};
|