Problem: the hexagonal refactor churns the backend tree for nine more phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper, compose/web image) must move to its own repo first so doc/layout rewrites land once on a backend-only tree. Change: - New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/ (updateURL repointed to oikos-web releases), compose/, own CI (web + desktop jobs), own deploy script (CI-green gate, TOCTOU guard, version-tagged images, prune-to-3), own webhook receiver on :9798 + launchd unit, own compose project publishing the same 8091:80. - Cutover executed on mac-mini in order: oikos stack's web service stopped+removed, oikos-web project brought up on 8091; outer Caddy untouched (targets the published port) — serving + Authentik flow + /wails 404 quirk verified post-cutover. - Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install targets, the compose web service, oikos-web from deploy.sh's fallback prune list; wails + go-keyring dropped from go.mod, vendor synced. - README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now point at the new repo; mbse + mascot design docs carry a path note. Risk: production SPA serving depends on the new pipeline now; rollback is versioned-image re-up of the old web service from a pre-split checkout (port 8091). Desktop builds installed before the split still check dtoro/oikos releases — one manual reinstall, noted in the oikos-web release notes. Verification: go vet, make test (race), make generate-check, golangci (no new findings; baseline down 400→365); post-cutover curls — localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
101 lines
2.4 KiB
JavaScript
101 lines
2.4 KiB
JavaScript
/**
|
|
* @fileoverview Rule to disallow a negated condition
|
|
* @author Alberto Rodríguez
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Disallow negated conditions",
|
|
recommended: false,
|
|
frozen: true,
|
|
url: "https://eslint.org/docs/latest/rules/no-negated-condition",
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
unexpectedNegated: "Unexpected negated condition.",
|
|
},
|
|
},
|
|
|
|
create(context) {
|
|
/**
|
|
* Determines if a given node is an if-else without a condition on the else
|
|
* @param {ASTNode} node The node to check.
|
|
* @returns {boolean} True if the node has an else without an if.
|
|
* @private
|
|
*/
|
|
function hasElseWithoutCondition(node) {
|
|
return node.alternate && node.alternate.type !== "IfStatement";
|
|
}
|
|
|
|
/**
|
|
* Determines if a given node is a negated unary expression
|
|
* @param {Object} test The test object to check.
|
|
* @returns {boolean} True if the node is a negated unary expression.
|
|
* @private
|
|
*/
|
|
function isNegatedUnaryExpression(test) {
|
|
return test.type === "UnaryExpression" && test.operator === "!";
|
|
}
|
|
|
|
/**
|
|
* Determines if a given node is a negated binary expression
|
|
* @param {Test} test The test to check.
|
|
* @returns {boolean} True if the node is a negated binary expression.
|
|
* @private
|
|
*/
|
|
function isNegatedBinaryExpression(test) {
|
|
return (
|
|
test.type === "BinaryExpression" &&
|
|
(test.operator === "!=" || test.operator === "!==")
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Determines if a given node has a negated if expression
|
|
* @param {ASTNode} node The node to check.
|
|
* @returns {boolean} True if the node has a negated if expression.
|
|
* @private
|
|
*/
|
|
function isNegatedIf(node) {
|
|
return (
|
|
isNegatedUnaryExpression(node.test) ||
|
|
isNegatedBinaryExpression(node.test)
|
|
);
|
|
}
|
|
|
|
return {
|
|
IfStatement(node) {
|
|
if (!hasElseWithoutCondition(node)) {
|
|
return;
|
|
}
|
|
|
|
if (isNegatedIf(node)) {
|
|
context.report({
|
|
node,
|
|
messageId: "unexpectedNegated",
|
|
});
|
|
}
|
|
},
|
|
ConditionalExpression(node) {
|
|
if (isNegatedIf(node)) {
|
|
context.report({
|
|
node,
|
|
messageId: "unexpectedNegated",
|
|
});
|
|
}
|
|
},
|
|
};
|
|
},
|
|
};
|