Files
oikos/web/node_modules/eslint/lib/rules/no-lonely-if.js
dtoro d4d99a7473
Some checks failed
ci / build-test (push) Has been cancelled
ci / docker-build (push) Has been cancelled
feat: Phase 1 — extract the client (web SPA + desktop) to dtoro/oikos-web
Problem: the hexagonal refactor churns the backend tree for nine more
phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper,
compose/web image) must move to its own repo first so doc/layout
rewrites land once on a backend-only tree.

Change:
- New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/
  (updateURL repointed to oikos-web releases), compose/, own CI (web +
  desktop jobs), own deploy script (CI-green gate, TOCTOU guard,
  version-tagged images, prune-to-3), own webhook receiver on :9798 +
  launchd unit, own compose project publishing the same 8091:80.
- Cutover executed on mac-mini in order: oikos stack's web service
  stopped+removed, oikos-web project brought up on 8091; outer Caddy
  untouched (targets the published port) — serving + Authentik flow +
  /wails 404 quirk verified post-cutover.
- Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI
  workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install
  targets, the compose web service, oikos-web from deploy.sh's fallback
  prune list; wails + go-keyring dropped from go.mod, vendor synced.
- README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now
  point at the new repo; mbse + mascot design docs carry a path note.

Risk: production SPA serving depends on the new pipeline now; rollback
is versioned-image re-up of the old web service from a pre-split
checkout (port 8091). Desktop builds installed before the split still
check dtoro/oikos releases — one manual reinstall, noted in the
oikos-web release notes.

Verification: go vet, make test (race), make generate-check, golangci
(no new findings; baseline down 400→365); post-cutover curls —
localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
2026-08-15 22:27:52 +02:00

127 lines
3.2 KiB
JavaScript

/**
* @fileoverview Rule to disallow if as the only statement in an else block
* @author Brandon Mills
*/
"use strict";
//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------
const astUtils = require("./utils/ast-utils");
//------------------------------------------------------------------------------
// Rule Definition
//------------------------------------------------------------------------------
/** @type {import('../types').Rule.RuleModule} */
module.exports = {
meta: {
type: "suggestion",
docs: {
description:
"Disallow `if` statements as the only statement in `else` blocks",
recommended: false,
frozen: true,
url: "https://eslint.org/docs/latest/rules/no-lonely-if",
},
schema: [],
fixable: "code",
messages: {
unexpectedLonelyIf:
"Unexpected if as the only statement in an else block.",
},
},
create(context) {
const sourceCode = context.sourceCode;
return {
IfStatement(node) {
const parent = node.parent,
grandparent = parent.parent;
if (
parent &&
parent.type === "BlockStatement" &&
parent.body.length === 1 &&
!astUtils.areBracesNecessary(parent, sourceCode) &&
grandparent &&
grandparent.type === "IfStatement" &&
parent === grandparent.alternate
) {
context.report({
node,
messageId: "unexpectedLonelyIf",
fix(fixer) {
const openingElseCurly =
sourceCode.getFirstToken(parent);
const closingElseCurly =
sourceCode.getLastToken(parent);
const elseKeyword =
sourceCode.getTokenBefore(openingElseCurly);
const tokenAfterElseBlock =
sourceCode.getTokenAfter(closingElseCurly);
const lastIfToken = sourceCode.getLastToken(
node.consequent,
);
const sourceText = sourceCode.getText();
if (
sourceText
.slice(
openingElseCurly.range[1],
node.range[0],
)
.trim() ||
sourceText
.slice(
node.range[1],
closingElseCurly.range[0],
)
.trim()
) {
// Don't fix if there are any non-whitespace characters interfering (e.g. comments)
return null;
}
if (
node.consequent.type !== "BlockStatement" &&
lastIfToken.value !== ";" &&
tokenAfterElseBlock &&
(node.consequent.loc.end.line ===
tokenAfterElseBlock.loc.start.line ||
/^[([/+`-]/u.test(
tokenAfterElseBlock.value,
) ||
lastIfToken.value === "++" ||
lastIfToken.value === "--")
) {
/*
* If the `if` statement has no block, and is not followed by a semicolon, make sure that fixing
* the issue would not change semantics due to ASI. If this would happen, don't do a fix.
*/
return null;
}
return fixer.replaceTextRange(
[
openingElseCurly.range[0],
closingElseCurly.range[1],
],
(elseKeyword.range[1] ===
openingElseCurly.range[0]
? " "
: "") + sourceCode.getText(node),
);
},
});
}
},
};
},
};