Problem: the hexagonal refactor churns the backend tree for nine more phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper, compose/web image) must move to its own repo first so doc/layout rewrites land once on a backend-only tree. Change: - New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/ (updateURL repointed to oikos-web releases), compose/, own CI (web + desktop jobs), own deploy script (CI-green gate, TOCTOU guard, version-tagged images, prune-to-3), own webhook receiver on :9798 + launchd unit, own compose project publishing the same 8091:80. - Cutover executed on mac-mini in order: oikos stack's web service stopped+removed, oikos-web project brought up on 8091; outer Caddy untouched (targets the published port) — serving + Authentik flow + /wails 404 quirk verified post-cutover. - Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install targets, the compose web service, oikos-web from deploy.sh's fallback prune list; wails + go-keyring dropped from go.mod, vendor synced. - README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now point at the new repo; mbse + mascot design docs carry a path note. Risk: production SPA serving depends on the new pipeline now; rollback is versioned-image re-up of the old web service from a pre-split checkout (port 8091). Desktop builds installed before the split still check dtoro/oikos releases — one manual reinstall, noted in the oikos-web release notes. Verification: go vet, make test (race), make generate-check, golangci (no new findings; baseline down 400→365); post-cutover curls — localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
179 lines
4.4 KiB
JavaScript
179 lines
4.4 KiB
JavaScript
/**
|
|
* @fileoverview A rule to disallow `this` keywords in contexts where the value of `this` is `undefined`.
|
|
* @author Toru Nagashima
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Helpers
|
|
//------------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Determines if the given code path is a code path with lexical `this` binding.
|
|
* That is, if `this` within the code path refers to `this` of surrounding code path.
|
|
* @param {CodePath} codePath Code path.
|
|
* @param {ASTNode} node Node that started the code path.
|
|
* @returns {boolean} `true` if it is a code path with lexical `this` binding.
|
|
*/
|
|
function isCodePathWithLexicalThis(codePath, node) {
|
|
return (
|
|
codePath.origin === "function" &&
|
|
node.type === "ArrowFunctionExpression"
|
|
);
|
|
}
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
dialects: ["javascript", "typescript"],
|
|
language: "javascript",
|
|
type: "suggestion",
|
|
|
|
defaultOptions: [{ capIsConstructor: true }],
|
|
|
|
docs: {
|
|
description:
|
|
"Disallow use of `this` in contexts where the value of `this` is `undefined`",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/no-invalid-this",
|
|
},
|
|
|
|
schema: [
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
capIsConstructor: {
|
|
type: "boolean",
|
|
},
|
|
},
|
|
additionalProperties: false,
|
|
},
|
|
],
|
|
|
|
messages: {
|
|
unexpectedThis: "Unexpected 'this'.",
|
|
},
|
|
},
|
|
|
|
create(context) {
|
|
const [{ capIsConstructor }] = context.options;
|
|
const stack = [],
|
|
sourceCode = context.sourceCode;
|
|
|
|
/**
|
|
* Gets the current checking context.
|
|
*
|
|
* The return value has a flag that whether or not `this` keyword is valid.
|
|
* The flag is initialized when got at the first time.
|
|
* @returns {{valid: boolean}}
|
|
* an object which has a flag that whether or not `this` keyword is valid.
|
|
*/
|
|
stack.getCurrent = function () {
|
|
const current = this.at(-1);
|
|
|
|
if (!current.init) {
|
|
current.init = true;
|
|
current.valid = !astUtils.isDefaultThisBinding(
|
|
current.node,
|
|
sourceCode,
|
|
{ capIsConstructor },
|
|
);
|
|
}
|
|
return current;
|
|
};
|
|
|
|
return {
|
|
onCodePathStart(codePath, node) {
|
|
if (isCodePathWithLexicalThis(codePath, node)) {
|
|
return;
|
|
}
|
|
|
|
if (codePath.origin === "program") {
|
|
const scope = sourceCode.getScope(node);
|
|
const features =
|
|
context.languageOptions.parserOptions.ecmaFeatures ||
|
|
{};
|
|
|
|
// `this` at the top level of scripts always refers to the global object
|
|
stack.push({
|
|
init: true,
|
|
node,
|
|
valid: !(
|
|
node.sourceType === "module" ||
|
|
(features.globalReturn &&
|
|
scope.childScopes[0].isStrict)
|
|
),
|
|
});
|
|
|
|
return;
|
|
}
|
|
|
|
/*
|
|
* `init: false` means that `valid` isn't determined yet.
|
|
* Most functions don't use `this`, and the calculation for `valid`
|
|
* is relatively costly, so we'll calculate it lazily when the first
|
|
* `this` within the function is traversed. A special case are non-strict
|
|
* functions, because `this` refers to the global object and therefore is
|
|
* always valid, so we can set `init: true` right away.
|
|
*/
|
|
stack.push({
|
|
init: !sourceCode.getScope(node).isStrict,
|
|
node,
|
|
valid: true,
|
|
});
|
|
},
|
|
|
|
onCodePathEnd(codePath, node) {
|
|
if (isCodePathWithLexicalThis(codePath, node)) {
|
|
return;
|
|
}
|
|
|
|
stack.pop();
|
|
},
|
|
|
|
"AccessorProperty > *.value"(node) {
|
|
stack.push({
|
|
init: true,
|
|
node,
|
|
valid: true,
|
|
});
|
|
},
|
|
|
|
"AccessorProperty:exit"() {
|
|
stack.pop();
|
|
},
|
|
|
|
// Reports if `this` of the current context is invalid.
|
|
ThisExpression(node) {
|
|
// Special case: skip `this` if it's the value of an AccessorProperty
|
|
if (
|
|
node.parent.type === "AccessorProperty" &&
|
|
node.parent.value === node
|
|
) {
|
|
return;
|
|
}
|
|
|
|
const current = stack.getCurrent();
|
|
|
|
if (current && !current.valid) {
|
|
context.report({
|
|
node,
|
|
messageId: "unexpectedThis",
|
|
});
|
|
}
|
|
},
|
|
};
|
|
},
|
|
};
|