Problem: the hexagonal refactor churns the backend tree for nine more phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper, compose/web image) must move to its own repo first so doc/layout rewrites land once on a backend-only tree. Change: - New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/ (updateURL repointed to oikos-web releases), compose/, own CI (web + desktop jobs), own deploy script (CI-green gate, TOCTOU guard, version-tagged images, prune-to-3), own webhook receiver on :9798 + launchd unit, own compose project publishing the same 8091:80. - Cutover executed on mac-mini in order: oikos stack's web service stopped+removed, oikos-web project brought up on 8091; outer Caddy untouched (targets the published port) — serving + Authentik flow + /wails 404 quirk verified post-cutover. - Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install targets, the compose web service, oikos-web from deploy.sh's fallback prune list; wails + go-keyring dropped from go.mod, vendor synced. - README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now point at the new repo; mbse + mascot design docs carry a path note. Risk: production SPA serving depends on the new pipeline now; rollback is versioned-image re-up of the old web service from a pre-split checkout (port 8091). Desktop builds installed before the split still check dtoro/oikos releases — one manual reinstall, noted in the oikos-web release notes. Verification: go vet, make test (race), make generate-check, golangci (no new findings; baseline down 400→365); post-cutover curls — localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
116 lines
2.6 KiB
JavaScript
116 lines
2.6 KiB
JavaScript
/**
|
|
* @fileoverview Enforces or disallows inline comments.
|
|
* @author Greg Cochard
|
|
*/
|
|
"use strict";
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
defaultOptions: [{}],
|
|
|
|
docs: {
|
|
description: "Disallow inline comments after code",
|
|
recommended: false,
|
|
frozen: true,
|
|
url: "https://eslint.org/docs/latest/rules/no-inline-comments",
|
|
},
|
|
|
|
schema: [
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
ignorePattern: {
|
|
type: "string",
|
|
},
|
|
},
|
|
additionalProperties: false,
|
|
},
|
|
],
|
|
|
|
messages: {
|
|
unexpectedInlineComment: "Unexpected comment inline with code.",
|
|
},
|
|
},
|
|
|
|
create(context) {
|
|
const sourceCode = context.sourceCode;
|
|
const [{ ignorePattern }] = context.options;
|
|
const customIgnoreRegExp =
|
|
ignorePattern && new RegExp(ignorePattern, "u");
|
|
|
|
/**
|
|
* Will check that comments are not on lines starting with or ending with code
|
|
* @param {ASTNode} node The comment node to check
|
|
* @private
|
|
* @returns {void}
|
|
*/
|
|
function testCodeAroundComment(node) {
|
|
const startLine = String(sourceCode.lines[node.loc.start.line - 1]),
|
|
endLine = String(sourceCode.lines[node.loc.end.line - 1]),
|
|
preamble = startLine.slice(0, node.loc.start.column).trim(),
|
|
postamble = endLine.slice(node.loc.end.column).trim(),
|
|
isPreambleEmpty = !preamble,
|
|
isPostambleEmpty = !postamble;
|
|
|
|
// Nothing on both sides
|
|
if (isPreambleEmpty && isPostambleEmpty) {
|
|
return;
|
|
}
|
|
|
|
// Matches the ignore pattern
|
|
if (customIgnoreRegExp && customIgnoreRegExp.test(node.value)) {
|
|
return;
|
|
}
|
|
|
|
// JSX Exception
|
|
if (
|
|
(isPreambleEmpty || preamble === "{") &&
|
|
(isPostambleEmpty || postamble === "}")
|
|
) {
|
|
const enclosingNode = sourceCode.getNodeByRangeIndex(
|
|
node.range[0],
|
|
);
|
|
|
|
if (
|
|
enclosingNode &&
|
|
enclosingNode.type === "JSXEmptyExpression"
|
|
) {
|
|
return;
|
|
}
|
|
}
|
|
|
|
// Don't report ESLint directive comments
|
|
if (astUtils.isDirectiveComment(node)) {
|
|
return;
|
|
}
|
|
|
|
context.report({
|
|
node,
|
|
messageId: "unexpectedInlineComment",
|
|
});
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
Program() {
|
|
sourceCode
|
|
.getAllComments()
|
|
.filter(token => token.type !== "Shebang")
|
|
.forEach(testCodeAroundComment);
|
|
},
|
|
};
|
|
},
|
|
};
|