Problem: the hexagonal refactor churns the backend tree for nine more phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper, compose/web image) must move to its own repo first so doc/layout rewrites land once on a backend-only tree. Change: - New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/ (updateURL repointed to oikos-web releases), compose/, own CI (web + desktop jobs), own deploy script (CI-green gate, TOCTOU guard, version-tagged images, prune-to-3), own webhook receiver on :9798 + launchd unit, own compose project publishing the same 8091:80. - Cutover executed on mac-mini in order: oikos stack's web service stopped+removed, oikos-web project brought up on 8091; outer Caddy untouched (targets the published port) — serving + Authentik flow + /wails 404 quirk verified post-cutover. - Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install targets, the compose web service, oikos-web from deploy.sh's fallback prune list; wails + go-keyring dropped from go.mod, vendor synced. - README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now point at the new repo; mbse + mascot design docs carry a path note. Risk: production SPA serving depends on the new pipeline now; rollback is versioned-image re-up of the old web service from a pre-split checkout (port 8091). Desktop builds installed before the split still check dtoro/oikos releases — one manual reinstall, noted in the oikos-web release notes. Verification: go vet, make test (race), make generate-check, golangci (no new findings; baseline down 400→365); post-cutover curls — localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
171 lines
4.2 KiB
JavaScript
171 lines
4.2 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag use of implied eval via setTimeout and setInterval
|
|
* @author James Allardice
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
const { getStaticValue } = require("@eslint-community/eslint-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Disallow the use of `eval()`-like methods",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/no-implied-eval",
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
impliedEval:
|
|
"Implied eval. Consider passing a function instead of a string.",
|
|
execScript: "Implied eval. Do not use execScript().",
|
|
},
|
|
},
|
|
|
|
create(context) {
|
|
const GLOBAL_CANDIDATES = Object.freeze([
|
|
"global",
|
|
"window",
|
|
"globalThis",
|
|
]);
|
|
const EVAL_LIKE_FUNC_PATTERN =
|
|
/^(?:set(?:Interval|Timeout)|execScript)$/u;
|
|
const sourceCode = context.sourceCode;
|
|
|
|
/**
|
|
* Checks whether a node is evaluated as a string or not.
|
|
* @param {ASTNode} node A node to check.
|
|
* @returns {boolean} True if the node is evaluated as a string.
|
|
*/
|
|
function isEvaluatedString(node) {
|
|
if (
|
|
(node.type === "Literal" && typeof node.value === "string") ||
|
|
node.type === "TemplateLiteral"
|
|
) {
|
|
return true;
|
|
}
|
|
if (node.type === "BinaryExpression" && node.operator === "+") {
|
|
return (
|
|
isEvaluatedString(node.left) ||
|
|
isEvaluatedString(node.right)
|
|
);
|
|
}
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* Reports if the `CallExpression` node has evaluated argument.
|
|
* @param {ASTNode} node A CallExpression to check.
|
|
* @returns {void}
|
|
*/
|
|
function reportImpliedEvalCallExpression(node) {
|
|
const [firstArgument] = node.arguments;
|
|
|
|
if (firstArgument) {
|
|
const staticValue = getStaticValue(
|
|
firstArgument,
|
|
sourceCode.getScope(node),
|
|
);
|
|
const isStaticString =
|
|
staticValue && typeof staticValue.value === "string";
|
|
const isString =
|
|
isStaticString || isEvaluatedString(firstArgument);
|
|
|
|
if (isString) {
|
|
const calleeName =
|
|
node.callee.type === "Identifier"
|
|
? node.callee.name
|
|
: astUtils.getStaticPropertyName(node.callee);
|
|
const isExecScript = calleeName === "execScript";
|
|
context.report({
|
|
node,
|
|
messageId: isExecScript ? "execScript" : "impliedEval",
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Reports calls of `implied eval` via the global references.
|
|
* @param {Variable} globalVar A global variable to check.
|
|
* @returns {void}
|
|
*/
|
|
function reportImpliedEvalViaGlobal(globalVar) {
|
|
const { references, name } = globalVar;
|
|
|
|
references.forEach(ref => {
|
|
const identifier = ref.identifier;
|
|
let node = identifier.parent;
|
|
|
|
while (astUtils.isSpecificMemberAccess(node, null, name)) {
|
|
node = node.parent;
|
|
}
|
|
|
|
if (
|
|
astUtils.isSpecificMemberAccess(
|
|
node,
|
|
null,
|
|
EVAL_LIKE_FUNC_PATTERN,
|
|
)
|
|
) {
|
|
const calleeNode =
|
|
node.parent.type === "ChainExpression"
|
|
? node.parent
|
|
: node;
|
|
const parent = calleeNode.parent;
|
|
|
|
if (
|
|
parent.type === "CallExpression" &&
|
|
parent.callee === calleeNode
|
|
) {
|
|
reportImpliedEvalCallExpression(parent);
|
|
}
|
|
}
|
|
});
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
CallExpression(node) {
|
|
if (
|
|
astUtils.isSpecificId(
|
|
node.callee,
|
|
EVAL_LIKE_FUNC_PATTERN,
|
|
) &&
|
|
sourceCode.isGlobalReference(node.callee)
|
|
) {
|
|
reportImpliedEvalCallExpression(node);
|
|
}
|
|
},
|
|
"Program:exit"(node) {
|
|
const globalScope = sourceCode.getScope(node);
|
|
|
|
GLOBAL_CANDIDATES.map(candidate =>
|
|
astUtils.getVariableByName(globalScope, candidate),
|
|
)
|
|
.filter(
|
|
globalVar => !!globalVar && globalVar.defs.length === 0,
|
|
)
|
|
.forEach(reportImpliedEvalViaGlobal);
|
|
},
|
|
};
|
|
},
|
|
};
|