Problem: the hexagonal refactor churns the backend tree for nine more phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper, compose/web image) must move to its own repo first so doc/layout rewrites land once on a backend-only tree. Change: - New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/ (updateURL repointed to oikos-web releases), compose/, own CI (web + desktop jobs), own deploy script (CI-green gate, TOCTOU guard, version-tagged images, prune-to-3), own webhook receiver on :9798 + launchd unit, own compose project publishing the same 8091:80. - Cutover executed on mac-mini in order: oikos stack's web service stopped+removed, oikos-web project brought up on 8091; outer Caddy untouched (targets the published port) — serving + Authentik flow + /wails 404 quirk verified post-cutover. - Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install targets, the compose web service, oikos-web from deploy.sh's fallback prune list; wails + go-keyring dropped from go.mod, vendor synced. - README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now point at the new repo; mbse + mascot design docs carry a path note. Risk: production SPA serving depends on the new pipeline now; rollback is versioned-image re-up of the old web service from a pre-split checkout (port 8091). Desktop builds installed before the split still check dtoro/oikos releases — one manual reinstall, noted in the oikos-web release notes. Verification: go vet, make test (race), make generate-check, golangci (no new findings; baseline down 400→365); post-cutover curls — localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
168 lines
4.5 KiB
JavaScript
168 lines
4.5 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag use of unnecessary semicolons
|
|
* @author Nicholas C. Zakas
|
|
* @deprecated in ESLint v8.53.0
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const FixTracker = require("./utils/fix-tracker");
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
deprecated: {
|
|
message: "Formatting rules are being moved out of ESLint core.",
|
|
url: "https://eslint.org/blog/2023/10/deprecating-formatting-rules/",
|
|
deprecatedSince: "8.53.0",
|
|
availableUntil: "11.0.0",
|
|
replacedBy: [
|
|
{
|
|
message:
|
|
"ESLint Stylistic now maintains deprecated stylistic core rules.",
|
|
url: "https://eslint.style/guide/migration",
|
|
plugin: {
|
|
name: "@stylistic/eslint-plugin",
|
|
url: "https://eslint.style",
|
|
},
|
|
rule: {
|
|
name: "no-extra-semi",
|
|
url: "https://eslint.style/rules/no-extra-semi",
|
|
},
|
|
},
|
|
],
|
|
},
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Disallow unnecessary semicolons",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/no-extra-semi",
|
|
},
|
|
|
|
fixable: "code",
|
|
schema: [],
|
|
|
|
messages: {
|
|
unexpected: "Unnecessary semicolon.",
|
|
},
|
|
},
|
|
|
|
create(context) {
|
|
const sourceCode = context.sourceCode;
|
|
|
|
/**
|
|
* Checks if a node or token is fixable.
|
|
* A node is fixable if it can be removed without turning a subsequent statement into a directive after fixing other nodes.
|
|
* @param {Token} nodeOrToken The node or token to check.
|
|
* @returns {boolean} Whether or not the node is fixable.
|
|
*/
|
|
function isFixable(nodeOrToken) {
|
|
const nextToken = sourceCode.getTokenAfter(nodeOrToken);
|
|
|
|
if (!nextToken || nextToken.type !== "String") {
|
|
return true;
|
|
}
|
|
const stringNode = sourceCode.getNodeByRangeIndex(
|
|
nextToken.range[0],
|
|
);
|
|
|
|
return !astUtils.isTopLevelExpressionStatement(stringNode.parent);
|
|
}
|
|
|
|
/**
|
|
* Reports an unnecessary semicolon error.
|
|
* @param {Node|Token} nodeOrToken A node or a token to be reported.
|
|
* @returns {void}
|
|
*/
|
|
function report(nodeOrToken) {
|
|
context.report({
|
|
node: nodeOrToken,
|
|
messageId: "unexpected",
|
|
fix: isFixable(nodeOrToken)
|
|
? fixer =>
|
|
/*
|
|
* Expand the replacement range to include the surrounding
|
|
* tokens to avoid conflicting with semi.
|
|
* https://github.com/eslint/eslint/issues/7928
|
|
*/
|
|
new FixTracker(fixer, context.sourceCode)
|
|
.retainSurroundingTokens(nodeOrToken)
|
|
.remove(nodeOrToken)
|
|
: null,
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Checks for a part of a class body.
|
|
* This checks tokens from a specified token to a next MethodDefinition or the end of class body.
|
|
* @param {Token} firstToken The first token to check.
|
|
* @returns {void}
|
|
*/
|
|
function checkForPartOfClassBody(firstToken) {
|
|
for (
|
|
let token = firstToken;
|
|
token.type === "Punctuator" &&
|
|
!astUtils.isClosingBraceToken(token);
|
|
token = sourceCode.getTokenAfter(token)
|
|
) {
|
|
if (astUtils.isSemicolonToken(token)) {
|
|
report(token);
|
|
}
|
|
}
|
|
}
|
|
|
|
return {
|
|
/**
|
|
* Reports this empty statement, except if the parent node is a loop.
|
|
* @param {Node} node A EmptyStatement node to be reported.
|
|
* @returns {void}
|
|
*/
|
|
EmptyStatement(node) {
|
|
const parent = node.parent,
|
|
allowedParentTypes = [
|
|
"ForStatement",
|
|
"ForInStatement",
|
|
"ForOfStatement",
|
|
"WhileStatement",
|
|
"DoWhileStatement",
|
|
"IfStatement",
|
|
"LabeledStatement",
|
|
"WithStatement",
|
|
];
|
|
|
|
if (!allowedParentTypes.includes(parent.type)) {
|
|
report(node);
|
|
}
|
|
},
|
|
|
|
/**
|
|
* Checks tokens from the head of this class body to the first MethodDefinition or the end of this class body.
|
|
* @param {Node} node A ClassBody node to check.
|
|
* @returns {void}
|
|
*/
|
|
ClassBody(node) {
|
|
checkForPartOfClassBody(sourceCode.getFirstToken(node, 1)); // 0 is `{`.
|
|
},
|
|
|
|
/**
|
|
* Checks tokens from this MethodDefinition to the next MethodDefinition or the end of this class body.
|
|
* @param {Node} node A MethodDefinition node of the start point.
|
|
* @returns {void}
|
|
*/
|
|
"MethodDefinition, PropertyDefinition, StaticBlock"(node) {
|
|
checkForPartOfClassBody(sourceCode.getTokenAfter(node));
|
|
},
|
|
};
|
|
},
|
|
};
|