Problem: the hexagonal refactor churns the backend tree for nine more phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper, compose/web image) must move to its own repo first so doc/layout rewrites land once on a backend-only tree. Change: - New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/ (updateURL repointed to oikos-web releases), compose/, own CI (web + desktop jobs), own deploy script (CI-green gate, TOCTOU guard, version-tagged images, prune-to-3), own webhook receiver on :9798 + launchd unit, own compose project publishing the same 8091:80. - Cutover executed on mac-mini in order: oikos stack's web service stopped+removed, oikos-web project brought up on 8091; outer Caddy untouched (targets the published port) — serving + Authentik flow + /wails 404 quirk verified post-cutover. - Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install targets, the compose web service, oikos-web from deploy.sh's fallback prune list; wails + go-keyring dropped from go.mod, vendor synced. - README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now point at the new repo; mbse + mascot design docs carry a path note. Risk: production SPA serving depends on the new pipeline now; rollback is versioned-image re-up of the old web service from a pre-split checkout (port 8091). Desktop builds installed before the split still check dtoro/oikos releases — one manual reinstall, noted in the oikos-web release notes. Verification: go vet, make test (race), make generate-check, golangci (no new findings; baseline down 400→365); post-cutover curls — localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
116 lines
2.4 KiB
JavaScript
116 lines
2.4 KiB
JavaScript
/**
|
|
* @fileoverview Rule to disallow uses of await inside of loops.
|
|
* @author Nat Mote (nmote)
|
|
*/
|
|
"use strict";
|
|
|
|
/**
|
|
* Check whether it should stop traversing ancestors at the given node.
|
|
* @param {ASTNode} node A node to check.
|
|
* @returns {boolean} `true` if it should stop traversing.
|
|
*/
|
|
function isBoundary(node) {
|
|
const t = node.type;
|
|
|
|
return (
|
|
t === "FunctionDeclaration" ||
|
|
t === "FunctionExpression" ||
|
|
t === "ArrowFunctionExpression" ||
|
|
/*
|
|
* Don't report the await expressions on for-await-of loop since it's
|
|
* asynchronous iteration intentionally.
|
|
*/
|
|
(t === "ForOfStatement" && node.await === true)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Check whether the given node is in loop.
|
|
* @param {ASTNode} node A node to check.
|
|
* @param {ASTNode} parent A parent node to check.
|
|
* @returns {boolean} `true` if the node is in loop.
|
|
*/
|
|
function isLooped(node, parent) {
|
|
switch (parent.type) {
|
|
case "ForStatement":
|
|
return (
|
|
node === parent.test ||
|
|
node === parent.update ||
|
|
node === parent.body
|
|
);
|
|
|
|
case "ForOfStatement":
|
|
case "ForInStatement":
|
|
return (
|
|
node === parent.body ||
|
|
(node === parent.left && node.kind === "await using")
|
|
);
|
|
|
|
case "WhileStatement":
|
|
case "DoWhileStatement":
|
|
return node === parent.test || node === parent.body;
|
|
|
|
default:
|
|
return false;
|
|
}
|
|
}
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "problem",
|
|
|
|
docs: {
|
|
description: "Disallow `await` inside of loops",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/no-await-in-loop",
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
unexpectedAwait: "Unexpected `await` inside a loop.",
|
|
},
|
|
},
|
|
create(context) {
|
|
/**
|
|
* Validate an await expression.
|
|
* @param {ASTNode} awaitNode An AwaitExpression or ForOfStatement node to validate.
|
|
* @returns {void}
|
|
*/
|
|
function validate(awaitNode) {
|
|
if (
|
|
awaitNode.type === "VariableDeclaration" &&
|
|
awaitNode.kind !== "await using"
|
|
) {
|
|
return;
|
|
}
|
|
|
|
if (awaitNode.type === "ForOfStatement" && !awaitNode.await) {
|
|
return;
|
|
}
|
|
|
|
let node = awaitNode;
|
|
let parent = node.parent;
|
|
|
|
while (parent && !isBoundary(parent)) {
|
|
if (isLooped(node, parent)) {
|
|
context.report({
|
|
node: awaitNode,
|
|
messageId: "unexpectedAwait",
|
|
});
|
|
return;
|
|
}
|
|
node = parent;
|
|
parent = parent.parent;
|
|
}
|
|
}
|
|
|
|
return {
|
|
AwaitExpression: validate,
|
|
ForOfStatement: validate,
|
|
VariableDeclaration: validate,
|
|
};
|
|
},
|
|
};
|