Problem: the hexagonal refactor churns the backend tree for nine more phases; the UI delivery stack (web/ SPA, cmd/desktop Wails wrapper, compose/web image) must move to its own repo first so doc/layout rewrites land once on a backend-only tree. Change: - New repo git.hubris.network/dtoro/oikos-web (v0.33.0): web/, desktop/ (updateURL repointed to oikos-web releases), compose/, own CI (web + desktop jobs), own deploy script (CI-green gate, TOCTOU guard, version-tagged images, prune-to-3), own webhook receiver on :9798 + launchd unit, own compose project publishing the same 8091:80. - Cutover executed on mac-mini in order: oikos stack's web service stopped+removed, oikos-web project brought up on 8091; outer Caddy untouched (targets the published port) — serving + Authentik flow + /wails 404 quirk verified post-cutover. - Stripped from oikos: web/, cmd/desktop/, compose/web/, desktop CI workflow, ci.yml web job, Makefile ui/desktop/desktop-package/install targets, the compose web service, oikos-web from deploy.sh's fallback prune list; wails + go-keyring dropped from go.mod, vendor synced. - README / CONTRIBUTING / AGENTS.md / .agents dev+operations docs now point at the new repo; mbse + mascot design docs carry a path note. Risk: production SPA serving depends on the new pipeline now; rollback is versioned-image re-up of the old web service from a pre-split checkout (port 8091). Desktop builds installed before the split still check dtoro/oikos releases — one manual reinstall, noted in the oikos-web release notes. Verification: go vet, make test (race), make generate-check, golangci (no new findings; baseline down 400→365); post-cutover curls — localhost:8091 200, /wails/runtime.js 404, outer Caddy 302 Authentik.
86 lines
1.9 KiB
JavaScript
86 lines
1.9 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag for-in loops without if statements inside
|
|
* @author Nicholas C. Zakas
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Require `for-in` loops to include an `if` statement",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/guard-for-in",
|
|
},
|
|
|
|
schema: [],
|
|
messages: {
|
|
wrap: "The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype.",
|
|
},
|
|
},
|
|
|
|
create(context) {
|
|
return {
|
|
ForInStatement(node) {
|
|
const body = node.body;
|
|
|
|
// empty statement
|
|
if (body.type === "EmptyStatement") {
|
|
return;
|
|
}
|
|
|
|
// if statement
|
|
if (body.type === "IfStatement") {
|
|
return;
|
|
}
|
|
|
|
// empty block
|
|
if (body.type === "BlockStatement" && body.body.length === 0) {
|
|
return;
|
|
}
|
|
|
|
// block with just if statement
|
|
if (
|
|
body.type === "BlockStatement" &&
|
|
body.body.length === 1 &&
|
|
body.body[0].type === "IfStatement"
|
|
) {
|
|
return;
|
|
}
|
|
|
|
// block that starts with if statement
|
|
if (
|
|
body.type === "BlockStatement" &&
|
|
body.body.length >= 1 &&
|
|
body.body[0].type === "IfStatement"
|
|
) {
|
|
const i = body.body[0];
|
|
|
|
// ... whose consequent is a continue
|
|
if (i.consequent.type === "ContinueStatement") {
|
|
return;
|
|
}
|
|
|
|
// ... whose consequent is a block that contains only a continue
|
|
if (
|
|
i.consequent.type === "BlockStatement" &&
|
|
i.consequent.body.length === 1 &&
|
|
i.consequent.body[0].type === "ContinueStatement"
|
|
) {
|
|
return;
|
|
}
|
|
}
|
|
|
|
context.report({ node, messageId: "wrap" });
|
|
},
|
|
};
|
|
},
|
|
};
|