dtoro
5686b9de40
Three UI issues reported after the neutral-gray redesign: - favicon.svg was still filled #58a6ff (the pre-redesign accent blue); changed to white to match the sidebar logo mark. - Sidebar nav items all showed a filled background even when inactive. Root cause: sidebar-menu-button.svelte (and -sub-button) rendered `data-active="false"` as a literal attribute, but Tailwind's bare `data-active:` variant matches attribute *presence*, not value — so data-active:bg-sidebar-accent applied to every item regardless of state. Fixed by emitting the attribute only when active (`isActive || undefined`), a latent bug in the vendored shadcn component that read as intentional until flagged. - Tailwind's preflight resets <button> to cursor: default, so no button in the app showed a pointer. Added one base rule restoring cursor: pointer for buttons, [role=button], links, summary, and select (respecting :disabled / aria-disabled) rather than annotating each call site — covers new interactive elements automatically. Risk: reversible_low (UI-only). Verification: verified in the browser preview that inactive sidebar items are transparent (only the current page shows a background), nav buttons report cursor: pointer via computed styles, and the favicon renders white in the tab. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
43 lines
1.7 KiB
Svelte
43 lines
1.7 KiB
Svelte
<script lang="ts">
|
|
import { cn, type WithElementRef } from "$lib/utils.js";
|
|
import type { Snippet } from "svelte";
|
|
import type { HTMLAnchorAttributes } from "svelte/elements";
|
|
|
|
let {
|
|
ref = $bindable(null),
|
|
children,
|
|
child,
|
|
class: className,
|
|
size = "md",
|
|
isActive = false,
|
|
...restProps
|
|
}: WithElementRef<HTMLAnchorAttributes> & {
|
|
child?: Snippet<[{ props: Record<string, unknown> }]>;
|
|
size?: "sm" | "md";
|
|
isActive?: boolean;
|
|
} = $props();
|
|
|
|
const mergedProps = $derived({
|
|
class: cn(
|
|
"text-sidebar-foreground ring-sidebar-ring hover:bg-sidebar-accent hover:text-sidebar-accent-foreground active:bg-sidebar-accent active:text-sidebar-accent-foreground [&>svg]:text-sidebar-accent-foreground data-active:bg-sidebar-accent data-active:text-sidebar-accent-foreground h-7 gap-2 rounded-md px-2 focus-visible:ring-2 data-[size=md]:text-sm data-[size=sm]:text-xs [&>svg]:size-4 flex min-w-0 -translate-x-px items-center overflow-hidden outline-hidden group-data-[collapsible=icon]:hidden disabled:pointer-events-none disabled:opacity-50 aria-disabled:pointer-events-none aria-disabled:opacity-50 [&>span:last-child]:truncate [&>svg]:shrink-0",
|
|
className
|
|
),
|
|
"data-slot": "sidebar-menu-sub-button",
|
|
"data-sidebar": "menu-sub-button",
|
|
"data-size": size,
|
|
// Tailwind's bare `data-active:` variant matches attribute *presence*,
|
|
// not its value — omit the attribute entirely when false instead of
|
|
// rendering data-active="false" (which the variant still matches).
|
|
"data-active": isActive || undefined,
|
|
...restProps,
|
|
});
|
|
</script>
|
|
|
|
{#if child}
|
|
{@render child({ props: mergedProps })}
|
|
{:else}
|
|
<a bind:this={ref} {...mergedProps}>
|
|
{@render children?.()}
|
|
</a>
|
|
{/if}
|