From b72267bd7201e78b49cbb946e82945ee9e3952ba Mon Sep 17 00:00:00 2001 From: dtoro Date: Sat, 11 Jul 2026 20:32:29 +0200 Subject: [PATCH] =?UTF-8?q?docs:=20nomos=20agent=20code=20review=20?= =?UTF-8?q?=E2=80=94=20mark=20all=20fixes=20done=20except=20deferred=20C1?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Every finding from the review is now implemented and verified live: A1 (3919ec3), B1+B2 (c5ffaec), A3 (926969a), D1-D3 (76f7630), A2 (c390164), B3 (6d4f6de), F1 (11c18e8). C1 (nomos gateway has no authentication) remains explicitly deferred per operator instruction. Kept in plans/ (not moved to done/) since C1 is still open, matching how other partially-complete plans in this index are tracked. Co-Authored-By: Claude Opus 4.8 --- plans/2026-07-11-nomos-agent-code-review.md | 15 ++++++++++++++- plans/index.md | 2 +- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/plans/2026-07-11-nomos-agent-code-review.md b/plans/2026-07-11-nomos-agent-code-review.md index a8335b0..dbf619e 100644 --- a/plans/2026-07-11-nomos-agent-code-review.md +++ b/plans/2026-07-11-nomos-agent-code-review.md @@ -1,6 +1,19 @@ # 2026-07-11 — Nomos agent code review: gaps and improvement plan -**Status:** Planned +**Status:** In Progress — 2026-07-11. Every finding except C1 (A1-A3, B1-B3, +D1-D3, E, F1) is fixed, tested, and verified live against the running stack. +C1 (unauthenticated nomos gateway) is explicitly deferred per operator +instruction ("leave auth out for these round of fixes") — the one item +keeping this out of `done/`. + +- A1 `3919ec3`, B1+B2 `c5ffaec`, A3 `926969a`, D1-D3 `76f7630`, + A2 `c390164`, B3 `6d4f6de`, F1 `11c18e8`. +- New `internal/safego` package (B1) and `cmd/nomos/store_test.go` (A2, plus + a regression test for the earlier plan-append fix) are the first automated + tests for any of this package's core logic — closing part of finding E, + though full coverage of agent.go/main.go remains future work. +- C1 remains open — nomos's gateway (port 8092) still has no authentication. + Revisit separately. ## Scope diff --git a/plans/index.md b/plans/index.md index 7baad0c..d871e9e 100644 --- a/plans/index.md +++ b/plans/index.md @@ -13,7 +13,7 @@ went sideways, open an investigation. | 2026-07-08 | [Control room web UI](2026-07-08-control-room-webui.md) | In Progress | | 2026-07-08 | [Liveness, drift, and UX cohesion](2026-07-08-liveness-drift-and-ux-cohesion.md) | In Progress — Phase 5 deferred | | 2026-07-10 | [General gated execution: unlimited actions, gated by risk](2026-07-10-general-gated-execution.md) | In Progress — enum retirement + auto-act revival still open | -| 2026-07-11 | [Nomos agent code review: gaps and improvement plan](2026-07-11-nomos-agent-code-review.md) | Planned | +| 2026-07-11 | [Nomos agent code review: gaps and improvement plan](2026-07-11-nomos-agent-code-review.md) | In Progress — only C1 (unauthenticated nomos gateway) still open, deferred | ## Done