dtoro
4e725c0b2b
The editor now runs Socrates' three Phase-0-validated detection prompts against the live model, persists the findings, and surfaces them in a new FindingsPanel beside the IssuesPanel. Click any finding to focus its linked element across rail + diagram. Re-detect after model edits to refresh against the new state. apps/web/lib/llm/prompts/socrates - detect-assumptions.md / detect-risks.md / detect-inconsistencies.md promoted verbatim from phase-0 (Phase 0 corpus validated them 10/10). apps/web/lib/llm/detect.ts - Three sequential detection passes (parallel was OOM-prone on 4B local models — Phase 0 lesson). Each pass uses the Phase 0 JSON schema with jsonObjectMode fallback + chatJSON repair-retry. Fail-soft per pass: one busted pass returns [] rather than blowing up the whole detect. - post-validate strips hallucinated element refs (drops findings whose refs ALL fail to resolve; keeps findings with zero refs since some inconsistencies are genuinely about absences). apps/web/prisma/schema.prisma - Finding table: kind / text / linkedElementIds (JSON) / confidence / severity / validationCode / status / modelVersion / provider / model. - ResearchFinding table reserved for the Tavily integration that comes next — schema in place so we don't have to migrate again. apps/web/lib/db/repo.ts - listOpenFindings(projectId), replaceFindings(...) — replaceFindings wipes prior open findings in a transaction and writes the new set so re-detect doesn't accumulate stale findings. apps/web/app/api/projects/[projectId]/findings/route.ts - GET returns persisted open findings. - POST runs detect, persists, returns findings + meta (provider, model, durationMs, strippedRefs, droppedFindings). apps/web/components/editor/FindingsPanel.tsx - New panel, anchored bottom-right just left of IssuesPanel. Shows count summary (asm / risk / inc), detect / re-detect button, list grouped by kind (inconsistencies first, then risks, then assumptions), per-finding glyph + tag + severity + confidence + linked refs. - Click a finding row → focus its first linked element via the same setFocusBlockId path the rail and IssuesPanel already use. - "stale" indicator when the model version has advanced past the one the findings were detected against. EditorShell wires version + projectId through to FindingsPanel. Smoke-tested end-to-end: 12 findings returned (5 asm / 4 risk / 3 inc), 0 hallucinated refs stripped, ~37s on local gemma-4-e4b. Sample assumption "students are willing to engage with an AI tutor that is programmed to refuse providing complete solutions" — specific to Aristotle's refusal_policy, not a generic startup truism. Deferred to follow-ups: inline rail/diagram badges from findings, auto-detect-on-save, Tavily research, experiment modal.
61 lines
2.1 KiB
TypeScript
61 lines
2.1 KiB
TypeScript
// GET /api/projects/[id]/findings — returns the project's open findings
|
|
// POST /api/projects/[id]/findings — runs detection, persists, returns the new set
|
|
|
|
import { NextResponse } from "next/server";
|
|
import { loadProject, listOpenFindings, replaceFindings } from "../../../../../lib/db/repo";
|
|
import { detectFindings } from "../../../../../lib/llm/detect";
|
|
|
|
export async function GET(_req: Request, { params }: { params: Promise<{ projectId: string }> }) {
|
|
const { projectId } = await params;
|
|
const findings = await listOpenFindings(projectId);
|
|
return NextResponse.json({
|
|
findings: findings.map(f => ({
|
|
id: f.id,
|
|
kind: f.kind,
|
|
text: f.text,
|
|
linkedElementIds: f.linkedElementIds,
|
|
confidence: f.confidence,
|
|
severity: f.severity,
|
|
validationCode: f.validationCode,
|
|
modelVersion: f.modelVersion,
|
|
provider: f.provider,
|
|
llmModel: f.llmModel,
|
|
})),
|
|
});
|
|
}
|
|
|
|
export async function POST(_req: Request, { params }: { params: Promise<{ projectId: string }> }) {
|
|
const { projectId } = await params;
|
|
try {
|
|
const { model, version } = await loadProject(projectId);
|
|
const result = await detectFindings(model);
|
|
const stored = await replaceFindings(projectId, result.findings, version, result.provider, result.model);
|
|
|
|
return NextResponse.json({
|
|
findings: stored.map(f => ({
|
|
id: f.id,
|
|
kind: f.kind,
|
|
text: f.text,
|
|
linkedElementIds: f.linkedElementIds,
|
|
confidence: f.confidence,
|
|
severity: f.severity,
|
|
validationCode: f.validationCode,
|
|
modelVersion: f.modelVersion,
|
|
provider: f.provider,
|
|
llmModel: f.llmModel,
|
|
})),
|
|
meta: {
|
|
provider: result.provider,
|
|
model: result.model,
|
|
inputTokens: result.inputTokens,
|
|
outputTokens: result.outputTokens,
|
|
durationMs: result.durationMs,
|
|
strippedRefs: result.strippedRefs,
|
|
droppedFindings: result.droppedFindings,
|
|
},
|
|
});
|
|
} catch (err) {
|
|
return NextResponse.json({ error: (err as Error).message }, { status: 500 });
|
|
}
|
|
}
|