Pivot to text-first column-stack workspace + merge-with-review across AI artifacts
Workspace - Pivot from "set of open panes" to a Finder-style miller column stack: TopBar / LeftSidebar / [section → entity → entity ...] / pinned text editor. openPanesStore is now an ordered Column[] with pushFrom / closeFrom / setStack; only one top-level section is rooted at a time. - New entity column panes: Term, Block, Association, Constraint, Requirement, Finding. Click-through navigation truncates deeper columns automatically. - LeftSidebar surfaces a pending-count chip per section (single-glance navigation cue) and spins its analyze ↻ via SVG Spinner whenever the LLM is working — including server-initiated runs caught by the runs poll, not just user-triggered ones. Analyze pipeline + persistence - Unified `concepts` pass (taxonomy + glossary in one LLM call) replaces the two-pass setup. Server still accepts ?section=taxonomy|glossary and normalizes them for back-compat. - model / requirements / detection (assumptions, risks, inconsistencies) + cross-layer validation rules (X1–X4: stale term link, unlinked formalism, undefined linked term, prose-only term). - Persistence: NarrativeDocument, ModelSnapshot, ChangelogEntry, TaxonomyTerm, RequirementEntry, Finding, AnalysisRun. Re-runs MERGE instead of replace: gentle update on existing items, suggested on new, deprecated on missing — same idiom for every artifact kind. User pins preserve "kept" decisions across re-analyses. - Migrations: pivot_text_first, add_requirement_linked_term, term_review_state, review_state_for_reqs_and_findings, add_term_definition_pinned. Concept ↔ ontology integration - linkedTermId on Block / Association / Constraint / Requirement. PromoteToolbar lets the user formalize a concept inline: + Block / + Association / + Constraint / + Requirement, all routed through applyOps so undo/redo and SSE work for free. - decideElement op for in-canvas keep/discard on review-pending model elements. User-authored definitions - TermColumn definition is click-to-edit. Save (Cmd-Enter / blur), Cancel (Esc), Reset to AI suggestion when pinned. - definitionPinned flag on TaxonomyTerm: future Analyze runs leave the user's text alone. setTermDefinition repo function + POST /api/projects/[id]/terms/[termId]/definition endpoint. - mergeTaxonomySuggestion + applyGlossaryDefinitions both pin-aware. UX/UI - StatusChip: single component for all state idioms (suggested, deprecated, accepted, dismissed, resolved, severity, validation code, confidence, warn). Replaces 5+ ad-hoc badge classes. - PaneControls (PaneViewTabs + PaneFilterChip): separates view-mode toggles from filter chips so toggling Pending no longer flips you off the current view. - PaneEmpty: unified empty-state with title + hint + action. - PaneDrawer: collapsible groups for Pending / Discarded review; cards group as Kept (top) → Pending (bottom drawer) → Discarded (Findings only, hidden when empty). Restore action recovers dismissed/resolved findings. - ConceptCard unifies Tree and A–Z views in Concepts; only Tree parents carry the chevron (no empty placeholder offset). - Type + spacing tokens (--text-xs..xl, --space-1..6, --lh-tight/ui/ prose, --radius-*) replace every ad-hoc value. - Buttons standardized to body sans 500 (was a mishmash of mono / display). - Card shells unified across Concepts / Requirements / Findings. Cleanup - Removed: LeftRail, FindingsPanel, IssuesPanel, SocratesDock, ProposalCard, SlashMenu, SlashExtension, slashSuggestion, CanvasHeader, TaxonomyPane, GlossaryPane, TermDetail (popover; now TermColumn). - Section ids in openPanesStore: dropped taxonomy/glossary, added concepts. localStorage migration runs on hydrate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
134
apps/web/lib/sysml/crossValidate.ts
Normal file
134
apps/web/lib/sysml/crossValidate.ts
Normal file
@@ -0,0 +1,134 @@
|
||||
// Cross-layer validation — checks the joins between taxonomy/glossary terms
|
||||
// and the SysML ontology. These rules run separately from the structural
|
||||
// SysML validator (validate.ts) because they need access to the term list,
|
||||
// which validate.ts deliberately doesn't know about.
|
||||
//
|
||||
// Rule codes are prefixed `X*` to distinguish them from S/M/T rules and to
|
||||
// make it easy for the FindingsPane to render them under their own group.
|
||||
//
|
||||
// Severities: X1 and X3 are warnings (the data is in a broken state and the
|
||||
// user almost certainly wants to fix it). X2 and X4 are soft hints — they
|
||||
// surface opportunities to formalize without being intrusive.
|
||||
|
||||
import type { ValidationIssue } from "./validate";
|
||||
import type { SysMLModel } from "./model";
|
||||
|
||||
export interface CrossTerm {
|
||||
id: string;
|
||||
label: string;
|
||||
linkedBlockId: string | null;
|
||||
}
|
||||
|
||||
export interface CrossValidateInput {
|
||||
model: SysMLModel;
|
||||
terms: CrossTerm[];
|
||||
/** How many times each term occurs in the prose document.
|
||||
* Optional — when absent, X4 is skipped. */
|
||||
occurrencesByTermId?: Record<string, number>;
|
||||
}
|
||||
|
||||
/** Threshold for X4: surface a "consider promoting" hint only when a term
|
||||
* appears at least this many times in prose. Tuned to avoid spam on
|
||||
* one-off mentions. */
|
||||
export const X4_OCCURRENCE_THRESHOLD = 3;
|
||||
|
||||
export function crossValidate(input: CrossValidateInput): ValidationIssue[] {
|
||||
const { model, terms, occurrencesByTermId } = input;
|
||||
const issues: ValidationIssue[] = [];
|
||||
|
||||
const termById = new Map(terms.map(t => [t.id, t]));
|
||||
const blockById = new Map(model.blocks.map(b => [b.id, b]));
|
||||
|
||||
// ─── X1 — element.linkedTermId points to a missing term ─────────────────
|
||||
|
||||
for (const b of model.blocks) {
|
||||
if (b.linkedTermId && !termById.has(b.linkedTermId)) {
|
||||
issues.push({
|
||||
code: "X1",
|
||||
severity: "warning",
|
||||
message: `Block "${b.label}" links to a term that no longer exists`,
|
||||
anchor: { kind: "block", id: b.id },
|
||||
});
|
||||
}
|
||||
}
|
||||
for (const a of model.associations) {
|
||||
if (a.linkedTermId && !termById.has(a.linkedTermId)) {
|
||||
issues.push({
|
||||
code: "X1",
|
||||
severity: "warning",
|
||||
message: `Association "${a.label || a.id}" links to a term that no longer exists`,
|
||||
anchor: { kind: "association", id: a.id },
|
||||
});
|
||||
}
|
||||
}
|
||||
for (const c of model.constraints) {
|
||||
if (c.linkedTermId && !termById.has(c.linkedTermId)) {
|
||||
issues.push({
|
||||
code: "X1",
|
||||
severity: "warning",
|
||||
message: `Constraint "${c.label}" links to a term that no longer exists`,
|
||||
anchor: { kind: "constraint", id: c.id },
|
||||
});
|
||||
}
|
||||
}
|
||||
for (const r of model.requirements) {
|
||||
if (r.linkedTermId && !termById.has(r.linkedTermId)) {
|
||||
issues.push({
|
||||
code: "X1",
|
||||
severity: "warning",
|
||||
message: `Requirement ${r.tag} links to a term that no longer exists`,
|
||||
anchor: { kind: "requirement", id: r.id },
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
// ─── X2 — formalism has no linkedTermId (soft hint) ─────────────────────
|
||||
|
||||
for (const b of model.blocks) {
|
||||
if (!b.linkedTermId) {
|
||||
issues.push({
|
||||
code: "X2",
|
||||
severity: "soft",
|
||||
message: `Block "${b.label}" is not anchored to a concept — naming it after a term keeps the model in sync with the document`,
|
||||
anchor: { kind: "block", id: b.id },
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
// ─── X3 — term.linkedBlockId is stale (block was deleted) ───────────────
|
||||
|
||||
for (const t of terms) {
|
||||
if (t.linkedBlockId && !blockById.has(t.linkedBlockId)) {
|
||||
issues.push({
|
||||
code: "X3",
|
||||
severity: "warning",
|
||||
message: `Concept "${t.label}" links to a block that no longer exists`,
|
||||
anchor: { kind: "term", id: t.id },
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
// ─── X4 — prose-frequent term not formalized anywhere ───────────────────
|
||||
|
||||
if (occurrencesByTermId) {
|
||||
const formalizedTermIds = new Set<string>();
|
||||
for (const b of model.blocks) if (b.linkedTermId) formalizedTermIds.add(b.linkedTermId);
|
||||
for (const a of model.associations) if (a.linkedTermId) formalizedTermIds.add(a.linkedTermId);
|
||||
for (const c of model.constraints) if (c.linkedTermId) formalizedTermIds.add(c.linkedTermId);
|
||||
for (const r of model.requirements) if (r.linkedTermId) formalizedTermIds.add(r.linkedTermId);
|
||||
|
||||
for (const t of terms) {
|
||||
const n = occurrencesByTermId[t.id] ?? 0;
|
||||
if (n < X4_OCCURRENCE_THRESHOLD) continue;
|
||||
if (formalizedTermIds.has(t.id)) continue;
|
||||
issues.push({
|
||||
code: "X4",
|
||||
severity: "soft",
|
||||
message: `Concept "${t.label}" appears ${n}× in prose but has no formalization — consider promoting it`,
|
||||
anchor: { kind: "term", id: t.id },
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
return issues;
|
||||
}
|
||||
Reference in New Issue
Block a user