Pivot to text-first column-stack workspace + merge-with-review across AI artifacts
Workspace - Pivot from "set of open panes" to a Finder-style miller column stack: TopBar / LeftSidebar / [section → entity → entity ...] / pinned text editor. openPanesStore is now an ordered Column[] with pushFrom / closeFrom / setStack; only one top-level section is rooted at a time. - New entity column panes: Term, Block, Association, Constraint, Requirement, Finding. Click-through navigation truncates deeper columns automatically. - LeftSidebar surfaces a pending-count chip per section (single-glance navigation cue) and spins its analyze ↻ via SVG Spinner whenever the LLM is working — including server-initiated runs caught by the runs poll, not just user-triggered ones. Analyze pipeline + persistence - Unified `concepts` pass (taxonomy + glossary in one LLM call) replaces the two-pass setup. Server still accepts ?section=taxonomy|glossary and normalizes them for back-compat. - model / requirements / detection (assumptions, risks, inconsistencies) + cross-layer validation rules (X1–X4: stale term link, unlinked formalism, undefined linked term, prose-only term). - Persistence: NarrativeDocument, ModelSnapshot, ChangelogEntry, TaxonomyTerm, RequirementEntry, Finding, AnalysisRun. Re-runs MERGE instead of replace: gentle update on existing items, suggested on new, deprecated on missing — same idiom for every artifact kind. User pins preserve "kept" decisions across re-analyses. - Migrations: pivot_text_first, add_requirement_linked_term, term_review_state, review_state_for_reqs_and_findings, add_term_definition_pinned. Concept ↔ ontology integration - linkedTermId on Block / Association / Constraint / Requirement. PromoteToolbar lets the user formalize a concept inline: + Block / + Association / + Constraint / + Requirement, all routed through applyOps so undo/redo and SSE work for free. - decideElement op for in-canvas keep/discard on review-pending model elements. User-authored definitions - TermColumn definition is click-to-edit. Save (Cmd-Enter / blur), Cancel (Esc), Reset to AI suggestion when pinned. - definitionPinned flag on TaxonomyTerm: future Analyze runs leave the user's text alone. setTermDefinition repo function + POST /api/projects/[id]/terms/[termId]/definition endpoint. - mergeTaxonomySuggestion + applyGlossaryDefinitions both pin-aware. UX/UI - StatusChip: single component for all state idioms (suggested, deprecated, accepted, dismissed, resolved, severity, validation code, confidence, warn). Replaces 5+ ad-hoc badge classes. - PaneControls (PaneViewTabs + PaneFilterChip): separates view-mode toggles from filter chips so toggling Pending no longer flips you off the current view. - PaneEmpty: unified empty-state with title + hint + action. - PaneDrawer: collapsible groups for Pending / Discarded review; cards group as Kept (top) → Pending (bottom drawer) → Discarded (Findings only, hidden when empty). Restore action recovers dismissed/resolved findings. - ConceptCard unifies Tree and A–Z views in Concepts; only Tree parents carry the chevron (no empty placeholder offset). - Type + spacing tokens (--text-xs..xl, --space-1..6, --lh-tight/ui/ prose, --radius-*) replace every ad-hoc value. - Buttons standardized to body sans 500 (was a mishmash of mono / display). - Card shells unified across Concepts / Requirements / Findings. Cleanup - Removed: LeftRail, FindingsPanel, IssuesPanel, SocratesDock, ProposalCard, SlashMenu, SlashExtension, slashSuggestion, CanvasHeader, TaxonomyPane, GlossaryPane, TermDetail (popover; now TermColumn). - Section ids in openPanesStore: dropped taxonomy/glossary, added concepts. localStorage migration runs on hydrate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
168
apps/web/components/text-canvas/ChipSuggestionExtension.ts
Normal file
168
apps/web/components/text-canvas/ChipSuggestionExtension.ts
Normal file
@@ -0,0 +1,168 @@
|
||||
// TipTap/ProseMirror plugin: dotted-underline decoration on text spans whose
|
||||
// surface form matches a taxonomy term label or synonym. Reads the term list
|
||||
// from the editor's storage (set by TextCanvas via `editor.storage.terms`).
|
||||
//
|
||||
// Click → convert the underlined span into a chip via the editor's
|
||||
// insertChip command. Hover → tooltip handled by CSS title attribute (we
|
||||
// stash the definition there so we don't need a portal).
|
||||
//
|
||||
// Decorations only apply over plain text, never inside a chip node (atomic).
|
||||
|
||||
import { Extension } from "@tiptap/core";
|
||||
import { Plugin, PluginKey } from "@tiptap/pm/state";
|
||||
import { Decoration, DecorationSet } from "@tiptap/pm/view";
|
||||
|
||||
interface TermLite {
|
||||
id: string;
|
||||
label: string;
|
||||
definition: string | null;
|
||||
synonyms: string[];
|
||||
linkedBlockId: string | null;
|
||||
}
|
||||
|
||||
const KEY = new PluginKey("chip-suggestion");
|
||||
|
||||
export const ChipSuggestionExtension = Extension.create({
|
||||
name: "chipSuggestion",
|
||||
|
||||
addProseMirrorPlugins() {
|
||||
const editor = this.editor;
|
||||
return [
|
||||
new Plugin({
|
||||
key: KEY,
|
||||
state: {
|
||||
init(_, state) {
|
||||
const terms = readTerms(editor);
|
||||
return buildDecorations(state.doc, terms);
|
||||
},
|
||||
apply(tr, oldSet, _oldState, newState) {
|
||||
// Always rebuild on doc change OR when the editor signals that the
|
||||
// term list might have changed (force-update meta, dispatched by
|
||||
// TextCanvas after analyze runs).
|
||||
if (tr.docChanged || tr.getMeta("force-update")) {
|
||||
const terms = readTerms(editor);
|
||||
return buildDecorations(newState.doc, terms);
|
||||
}
|
||||
return oldSet.map(tr.mapping, tr.doc);
|
||||
},
|
||||
},
|
||||
props: {
|
||||
decorations(state) {
|
||||
return KEY.getState(state);
|
||||
},
|
||||
handleClick(view, _pos, ev) {
|
||||
const target = ev.target as HTMLElement | null;
|
||||
if (!target) return false;
|
||||
const span = target.closest(".chip-suggestion") as HTMLElement | null;
|
||||
if (!span) return false;
|
||||
const from = parseInt(span.dataset.from ?? "", 10);
|
||||
const to = parseInt(span.dataset.to ?? "", 10);
|
||||
const termId = span.dataset.termId ?? "";
|
||||
const label = span.dataset.label ?? span.innerText;
|
||||
if (Number.isNaN(from) || Number.isNaN(to) || !termId) return false;
|
||||
|
||||
// Replace the span with a chip node.
|
||||
const { tr } = view.state;
|
||||
const chipType = view.state.schema.nodes.chip;
|
||||
if (!chipType) return false;
|
||||
tr.replaceWith(
|
||||
from,
|
||||
to,
|
||||
chipType.create({ kind: "block", refId: termId, label })
|
||||
);
|
||||
view.dispatch(tr);
|
||||
return true;
|
||||
},
|
||||
},
|
||||
}),
|
||||
];
|
||||
},
|
||||
});
|
||||
|
||||
function readTerms(editor: { storage: unknown }): TermLite[] {
|
||||
const storage = editor.storage as Record<string, unknown>;
|
||||
const raw = storage?.terms;
|
||||
if (!Array.isArray(raw)) return [];
|
||||
return (raw as TermLite[]).filter(t => t && typeof t.label === "string");
|
||||
}
|
||||
|
||||
interface MatchSpec {
|
||||
pattern: RegExp;
|
||||
term: TermLite;
|
||||
surface: string;
|
||||
}
|
||||
|
||||
function buildPatterns(terms: TermLite[]): MatchSpec[] {
|
||||
const specs: MatchSpec[] = [];
|
||||
for (const t of terms) {
|
||||
const surfaces = dedupe([t.label, ...t.synonyms]).filter(s => s.trim().length >= 2);
|
||||
for (const s of surfaces) {
|
||||
specs.push({
|
||||
pattern: new RegExp(`\\b${escapeRegex(s)}\\b`, "gi"),
|
||||
term: t,
|
||||
surface: s,
|
||||
});
|
||||
}
|
||||
}
|
||||
// Match longer phrases first so "Socratic Tutor" wins over "Tutor".
|
||||
specs.sort((a, b) => b.surface.length - a.surface.length);
|
||||
return specs;
|
||||
}
|
||||
|
||||
function buildDecorations(doc: import("@tiptap/pm/model").Node, terms: TermLite[]): DecorationSet {
|
||||
if (terms.length === 0) return DecorationSet.empty;
|
||||
const specs = buildPatterns(terms);
|
||||
const decos: Decoration[] = [];
|
||||
|
||||
doc.descendants((node, pos) => {
|
||||
if (!node.isText || !node.text) return;
|
||||
// Skip text nodes that are inside a chip — chips are atomic, but be safe.
|
||||
const text = node.text;
|
||||
const occupied: Array<[number, number]> = []; // [start, end) within the text node
|
||||
for (const spec of specs) {
|
||||
spec.pattern.lastIndex = 0;
|
||||
let m: RegExpExecArray | null;
|
||||
while ((m = spec.pattern.exec(text)) !== null) {
|
||||
const start = m.index;
|
||||
const end = start + m[0].length;
|
||||
if (overlaps(occupied, start, end)) continue;
|
||||
occupied.push([start, end]);
|
||||
const from = pos + start;
|
||||
const to = pos + end;
|
||||
decos.push(
|
||||
Decoration.inline(from, to, {
|
||||
class: "chip-suggestion",
|
||||
"data-term-id": spec.term.id,
|
||||
"data-label": spec.term.label,
|
||||
"data-from": String(from),
|
||||
"data-to": String(to),
|
||||
title: spec.term.definition ?? "",
|
||||
})
|
||||
);
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
return DecorationSet.create(doc, decos);
|
||||
}
|
||||
|
||||
function overlaps(ranges: Array<[number, number]>, a: number, b: number): boolean {
|
||||
for (const [s, e] of ranges) if (a < e && b > s) return true;
|
||||
return false;
|
||||
}
|
||||
|
||||
function dedupe(xs: string[]): string[] {
|
||||
const seen = new Set<string>();
|
||||
const out: string[] = [];
|
||||
for (const x of xs) {
|
||||
const k = x.trim().toLowerCase();
|
||||
if (!k || seen.has(k)) continue;
|
||||
seen.add(k);
|
||||
out.push(x.trim());
|
||||
}
|
||||
return out;
|
||||
}
|
||||
|
||||
function escapeRegex(s: string): string {
|
||||
return s.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
|
||||
}
|
||||
Reference in New Issue
Block a user